Skip to content

fix: update keys of groupBy as per mapping#1423

Merged
rsbh merged 1 commit intomainfrom
fix_admin_ui_datatable
Feb 26, 2026
Merged

fix: update keys of groupBy as per mapping#1423
rsbh merged 1 commit intomainfrom
fix_admin_ui_datatable

Conversation

@rsbh
Copy link
Member

@rsbh rsbh commented Feb 26, 2026

Summary

Changes

Technical Details

Test Plan

  • Manual testing completed
  • Build and type checking passes

@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Building Building Preview, Comment Feb 26, 2026 4:21am

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 998a657 and eb3cf97.

📒 Files selected for processing (1)
  • web/sdk/admin/utils/transform-query.ts
📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved group by field handling in data table queries to ensure consistent field naming when field mappings are available.

Walkthrough

The transformDataTableQueryToRQLRequest function was updated to apply field name mapping to the groupBy parameter. The group_by array now maps each field through fieldNameMapping when available, using optional chaining to preserve unmapped fields.

Changes

Cohort / File(s) Summary
Field mapping in query transformation
web/sdk/admin/utils/transform-query.ts		 Updated groupBy mapping to apply fieldNameMapping to each field in the group_by array using optional chaining (fieldNameMapping?.[field] ?? field).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

paanSinghCoder
paanSinghCoder approved these changes Feb 26, 2026
View reviewed changes
Copy link
Contributor

@paanSinghCoder paanSinghCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsbh I think there are a few other places as well where camel casing is sent to the api.

@rsbh rsbh merged commit 4c966ab into main Feb 26, 2026
8 checks passed
@rsbh rsbh deleted the fix_admin_ui_datatable branch February 26, 2026 04:26
@coderabbitai coderabbitai bot mentioned this pull request Mar 9, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paanSinghCoder paanSinghCoder paanSinghCoder approved these changes

@rohilsurana rohilsurana Awaiting requested review from rohilsurana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsbh @paanSinghCoder