Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughSummary by CodeRabbit
WalkthroughVersion pinning changes applied across multiple package.json files within the web directory. The caret range specifiers for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request Test Coverage Report for Build 22295324589Details
💛 - Coveralls |
paanSinghCoder
left a comment
There was a problem hiding this comment.
Looking at this scenario, I think we should consider removing^ for other crucial packages as well.
It will add an overhead for us to manually upgrade packages but will keep things predictable.
Summary
This PR hardcodes connect-query to version 2.1.1
We were using 2.1.1 before, but recently we started using 2.2.0 because of the
^in the package.json and the need to update the pnpm lock file.The issue is that our pageQuery is nested inside the
query. But we were passingqueryas the key, since we can't passquery.offset, as it doesn't support that and it will throw TS issue.But in the recent changes to the library, it ignores the page query when generating the infinite query key.
We were passing
queryas the page query and search, and the filter was nested inside it, and they stopped working.Either we move the
offsetouside query or add support for nested keys in connect-query.An issue has been raised in connect-query as well connectrpc/connect-query-es#569