Skip to content

refactor(preference): rename custom_traits_path to additional_traits_path#1386

Merged
whoAbhishekSah merged 1 commit intomainfrom
feat/rename-custom-traits-to-additional-traits
Feb 17, 2026
Merged

refactor(preference): rename custom_traits_path to additional_traits_path#1386
whoAbhishekSah merged 1 commit intomainfrom
feat/rename-custom-traits-to-additional-traits

Conversation

@whoAbhishekSah
Copy link
Member

@whoAbhishekSah whoAbhishekSah commented Feb 17, 2026 •
edited
Loading

Summary

  • Renames custom_traits_path config field to additional_traits_path in app config
  • Updates all related references (comments, variable names) from "custom traits" to "additional traits"

Test plan

  • go build passes
  • TestLoadTraitsFromFile tests pass
  • Verify local run

🤖 Generated with Claude Code

@whoAbhishekSah @claude
feat(preference): rename custom_traits_path to additional_traits_path
44cfbbb 
Rename the config field and all related references from "custom traits"
to "additional traits" for consistency with deployment naming.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Feb 17, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Feb 17, 2026 5:19am

@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This pull request renames terminology from "custom traits" to "additional traits" across configuration and preference modules. Changes include field names in the configuration struct, variable names in merging logic, configuration path references, error messages, and descriptive comments. No functional behavior is altered.

Changes

Cohort / File(s) Summary
Terminology Refactoring
cmd/serve.go, core/preference/config.go, pkg/server/config.go		 Rename configuration field, variable names, comments, and error messages from "custom traits" to "additional traits". Configuration path changes from CustomTraitsPath to AdditionalTraitsPath with corresponding YAML/mapstructure tag updates. Loop variable in preference merging logic renamed from customTrait to additionalTrait. All changes are consistent across files with no behavioral modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
Description check ✅ Passed The PR description is mostly complete with Summary and Test Plan sections, though the Technical Details section is missing.
Title check ✅ Passed The title accurately describes the main change: renaming custom_traits_path to additional_traits_path across multiple files and related references.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/rename-custom-traits-to-additional-traits

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

coveralls commented Feb 17, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 22086878156

Details

  • 5 of 8 (62.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.323%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/serve.go 0 3 0.0%
Totals Coverage Status
Change from base Build 22059334847: 0.0%
Covered Lines: 16156
Relevant Lines: 42158
💛 - Coveralls

@whoAbhishekSah whoAbhishekSah changed the title feat(preference): rename custom_traits_path to additional_traits_path refactor(preference): rename custom_traits_path to additional_traits_path Feb 17, 2026
@whoAbhishekSah whoAbhishekSah merged commit b9f0e27 into main Feb 17, 2026
8 checks passed
@whoAbhishekSah whoAbhishekSah deleted the feat/rename-custom-traits-to-additional-traits branch February 17, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@whoAbhishekSah @coveralls @rohilsurana