fix(ci): remove dind service causing Docker version mismatch#1382
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughRemoved Docker-in-Docker (dind) service definitions from the smoke and regression jobs in the GitHub Actions workflow and removed the smoke job step that installed the spicedb binary; no other workflow logic or steps were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
The CI was failing with Docker API version mismatch: "client version 1.40 is too old. Minimum supported API version is 1.44" Changes: - Remove dind service from smoke and regression jobs (unnecessary, ubuntu-latest has Docker pre-installed) - Remove authzed/action-spicedb step (the e2e tests use ory/dockertest to spin up SpiceDB containers directly, the action was not needed) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
55cfa07 to
e0cab56
Compare
Pull Request Test Coverage Report for Build 22011575967Details
💛 - Coveralls |
rsbh
approved these changes
Feb 16, 2026
paanSinghCoder
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix smoke and regression test failures caused by Docker API version mismatch.
Problem
The CI was failing with:
Root Cause
Two issues were identified:
Unnecessary
dindservice: The Docker-in-Docker service was running Docker daemon v24.0.2 (API 1.44+), but the GitHub Actions runner's Docker client uses an older API (1.40), causing a version mismatch.Unnecessary
authzed/action-spicedbaction: This action was not needed because the e2e tests useory/dockertestGo library to spin up SpiceDB containers directly. The action was likely causing the Docker version mismatch by attempting to use Docker in an incompatible way.Same changes applied to the
regressionjob.🤖 Generated with Claude Code