feat(preference): add scope filtering to Filter struct and repository#1367
Merged
whoAbhishekSah merged 2 commits intomainfrom Feb 4, 2026
Merged
feat(preference): add scope filtering to Filter struct and repository#1367whoAbhishekSah merged 2 commits intomainfrom
whoAbhishekSah merged 2 commits intomainfrom
Conversation
Add ScopeType and ScopeID fields to the preference Filter struct to enable querying preferences by their scope. The repository List method now applies scope filtering, defaulting to global scope when not specified. This enables queries like "get user X's preferences scoped to org Y". - Add ScopeType/ScopeID to Filter struct - Update List() to filter by scope (defaults to global) - Add unit tests for scope filtering Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 21627783205Details
💛 - Coveralls |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rohilsurana
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScopeTypeandScopeIDfields topreference.FilterstructList()to filter by scope (defaults to global when not specified)Related: #1347
Details
This enables querying preferences by their scope, e.g., "get user X's preferences scoped to org Y".
When no scope is provided in the filter, defaults to global scope (
app/platform+ zero UUID) to maintain backward compatibility.Test Plan
go test ./internal/store/postgres/... -run TestPreferenceRepositorymake e2e-regression-testListUserPreferencesreturns only global-scoped preferences (unchanged behavior)ListCurrentUserPreferencesreturns only global-scoped preferences (unchanged behavior)🤖 Generated with Claude Code