Skip to content

fix #39 Error managing the script_root part of original requested URL …#40

Closed
ralcini wants to merge 2 commits into
rayluo:devfrom
ralcini:dev
Closed

fix #39 Error managing the script_root part of original requested URL …#40
ralcini wants to merge 2 commits into
rayluo:devfrom
ralcini:dev

Conversation

@ralcini

@ralcini ralcini commented Oct 3, 2024

Copy link
Copy Markdown

Adding the script_root and normalizing double or more "/" due to the concatenation operation

@ralcini ralcini changed the title fix #39 Error managing the script_root part of orginal requested URL … fix #39 Error managing the script_root part of original requested URL … Oct 3, 2024
@ralcini

ralcini commented Oct 3, 2024

Copy link
Copy Markdown
Author

the issue seems to affect the https://github.com/Azure-Samples/ms-identity-python too

@rayluo rayluo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another PR #41 uses other Flask built-in request attributes to avoid using re, and also make the improvement available for Quart. Closing this one here, but still THANK YOU for inspiring us!

@rayluo

rayluo commented Oct 20, 2024

Copy link
Copy Markdown
Owner

Replaced by #41

@rayluo rayluo closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants