Introduce an init_app(app) for factory pattern#31
Merged
Merged
Conversation
pamelafox
reviewed
Jun 10, 2024
pamelafox
approved these changes
Jun 10, 2024
pamelafox
left a comment
Contributor
There was a problem hiding this comment.
Nice! The init_app method is how I often initiate other extensions, so this seems right? I assume you've tried this out in a Flask app.
|
I've tested in my app, worked like a charm. Except that the linter did not like that I was passing None to Auth. |
Owner
Author
|
Polished the previous proof-of-concept (PoC), and applied it to Quart, manually tested with my two samples (which will be pushed soon in their own PRs in different repos). @joaooliveira-proof , if you are still interested, please pull the latest branch and test it again. It shall be a drop-in replacement of the previous PoC, except that the linter shall be happy now. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proof-of-concept may close #24. See if that meets your need, @pamelafox . If it looks good, I will see if I can apply same changes to Quart.