Merged
Conversation
Contributor
Author
|
@rayluo Please review |
Owner
|
Thanks for bringing the usage of I incline to put this PR on-hold, though, and suggest you (and I can do it, too) to add a similar PR into MSAL Python's repo. Because that library has more frequent release cadence, so that we will be able to actually "test" its effect on PyPI, before we confidently apply similar changes into many more repositories. |
rayluo
approved these changes
Apr 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be nice if pypi.org showed a link to the documentation. I think this is how it's specified, but all the docs these days show pyproject.toml, not setup.cfg, so I'm not positive.