[Spotify Player] Improve Spotify Player extension#9511
Merged
peduarte merged 4 commits intoraycast:mainfrom Dec 11, 2023
jatindotdev:ext/spotify-player
Merged
[Spotify Player] Improve Spotify Player extension#9511peduarte merged 4 commits intoraycast:mainfrom jatindotdev:ext/spotify-player
peduarte merged 4 commits intoraycast:mainfrom
jatindotdev:ext/spotify-player
Conversation
- feat: add device selection command - chore: add error handling and failure toast to PlayAction component - chore: improve error messages - feat: auto select device to play - Initial commit
Collaborator
|
Thank you for your contribution! 🎉 🔔 @mattisssa @peduarte @sxn @dillionverma @andreaselia @stuart @tonka3000 @dancannon @pernielsentikaer @stevensd2m @erics118 @hjoelh @hobhouse @bkeys818 you might want to have a look. |
Contributor
Author
|
@peduarte would love to get your review on the features and changes 😀 also this is one of my first feature contributions so excited!! |
Closed
peduarte
approved these changes
Dec 11, 2023
Contributor
|
Hey thanks for this! Appreciate the contribution 🙏 |
Collaborator
|
Published to the Raycast Store: |
Collaborator
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features & Bug Fixes
Select Devicecommand to select the device to play music on.Liked Songsplaylist.Liked Songsplaylist.Why this way?
Important
It doesn’t break any existing flow or functioning of the extension, just improves and adds support for people who use daemon service to play songs from spotify.
So, i don’t use Spotify app in my mac to play songs, i have
spotifydservice running and I control it using this extension or my phone. But every time there is no music playing and one would try to play the playlist or a song, it tries to open spotify app and it crashes (becz i dont have it), so i have to select my device and start music from my phone then i can control it from here.I have improved this by adding a independent command to select a device to play song and doing better error handling.
If the user wants to select device before hand, use the
Select Devicecommand to select a device.Now when tries to play something it checks.
Screencast
auto-select-device.mp4
device-select-command.mp4
show-songs-for-liked-playlist.mp4
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder