Skip to content

Update tmdb extension#9508

Merged
pernielsentikaer merged 2 commits intoraycast:mainfrom
j3lte:ext/tmdb
Dec 5, 2023
Merged

Update tmdb extension#9508
pernielsentikaer merged 2 commits intoraycast:mainfrom
j3lte:ext/tmdb

Conversation

@j3lte
Copy link
Contributor

@j3lte j3lte commented Dec 1, 2023

Description

Screencast

Checklist

- Update Changelog
- Add \'Copy TMDB ID\' to Detail Pages
- Feature #9502 add ability to copy title id from search
- Initial commit
@j3lte j3lte requested a review from thomaslombart as a code owner December 1, 2023 19:54
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: tmdb Issues related to the tmdb extension labels Dec 1, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Dec 1, 2023

Thank you for your contribution! 🎉

🔔 @Aayush9029 @andreaselia @thomaslombart you might want to have a look.

@andreaselia
Copy link
Contributor

Looks good to me, but do we really need to display the ID we are copying? Could the action simply be "Copy TMDB ID"? Just thinking if it's useful to show the ID here or better to keep it simple 🤔

@Aayush9029
Copy link
Contributor

Aayush9029 commented Dec 2, 2023

LGTM

imo, It’s fine to display the ID since the length of the string is small.

@j3lte
Copy link
Contributor Author

j3lte commented Dec 2, 2023

@andreaselia I was thinking of that, but the ID isn't shown anywhere, hence why I would add it in the Action menu. That way the user knows what it copied. It's only a few numbers, so it wouldn't mess up the Action panel.

If the ID was displayed in the Details, I would remove it from being displayed in the Action title I guess, does that make sense?

Let me know if I should remove it from the title :)

@thomaslombart
Copy link
Contributor

Let me know if we should keep the movie ID in the action or not. I'd be in favor of having it as just "Copy TMDb ID" since it's cleaner and seeing the ID doesn't provide much value, but that's just my two cents 🙂

@andreaselia
Copy link
Contributor

I agree, it doesn't provide additional value to the user seeing it rather than just copying it.

If we did want to display the ID somewhere, perhaps we could add it below "votes" here?

CleanShot 2023-12-03 at 22 18 04@2x

- Linting
- Remove TMDB ID from action title, add ID to detail
@j3lte
Copy link
Contributor Author

j3lte commented Dec 4, 2023

@andreaselia @thomaslombart I updated the PR, I removed the ID from the Action title, added it to the Details. See screenshots:

edit: This is only added to the details screen for Search, not the other detail pages

Screenshot 2023-12-04 at 12 40 06
Screenshot 2023-12-04 at 12 41 04

@andreaselia
Copy link
Contributor

The looks good, nice work dude - I'm happy for this to be merged @thomaslombart 👍

@pernielsentikaer pernielsentikaer merged commit 68c49cb into raycast:main Dec 5, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/Aayush9029/tmdb

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@j3lte).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@j3lte j3lte deleted the ext/tmdb branch December 13, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: tmdb Issues related to the tmdb extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants