Skip to content

feat(visual-studio-code): add open in terminal action#9443

Merged
pernielsentikaer merged 2 commits intoraycast:mainfrom
tmwrnr:feature/vs-code/open-in-terminal
Nov 28, 2023
Merged

feat(visual-studio-code): add open in terminal action#9443
pernielsentikaer merged 2 commits intoraycast:mainfrom
tmwrnr:feature/vs-code/open-in-terminal

Conversation

@tmwrnr
Copy link
Contributor

@tmwrnr tmwrnr commented Nov 28, 2023

Description

Add an action to open in the preferred terminal app. The action will only be displayed when the selected item is a directory. Users can modify their preferred terminal app in the commands settings.

The action was added because the default macOS Terminal app cannot be selected through the Open With... action. The new action allows users with other terminal apps to open the directory faster using shortcuts.

I also removed any unused imports.

Resolves #9429

Screencast

SCR-20231128-gfpp

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: visual-studio-code-recent-projects Issues related to the visual-studio-code-recent-projects extension labels Nov 28, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 28, 2023

Thank you for your contribution! 🎉

🔔 @thomaspaulmann @iainsimmons @macbookandrew @cy-98 @immint023 @vimtor @tonka3000 @aka-rabbi-inv @oilbeater @QIanGua @hakob8956 @erics118 you might want to have a look.

@raycastbot raycastbot added the OP is contributor The OP of the PR is a contributor of the extension label Nov 28, 2023
@pernielsentikaer
Copy link
Collaborator

Hi @tmwrnr 👋

I just moved the code to ExtensionPreferences instead to match the rest of the code and let the typescript automatically pick up preferences by itself. Do you mind checking that I didn't break something 🙂

@pernielsentikaer pernielsentikaer self-assigned this Nov 28, 2023
@tmwrnr
Copy link
Contributor Author

tmwrnr commented Nov 28, 2023

Hi @pernielsentikaer,

Thanks, it works as intended! I wasn't sure where to put the preferences, but I think they'll be more noticeable in the extension preferences, just like you did.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 8e5c6f9 into raycast:main Nov 28, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/thomas/visual-studio-code

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@tmwrnr tmwrnr deleted the feature/vs-code/open-in-terminal branch November 28, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: visual-studio-code-recent-projects Issues related to the visual-studio-code-recent-projects extension OP is contributor The OP of the PR is a contributor of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Visual Studio Code] Open With… menu not showing Terminal app

3 participants