Skip to content

Update jwt-decoder extension#9442

Merged
pernielsentikaer merged 4 commits intoraycast:mainfrom
zhhanging:ext/jwt-decoder
Nov 30, 2023
Merged

Update jwt-decoder extension#9442
pernielsentikaer merged 4 commits intoraycast:mainfrom
zhhanging:ext/jwt-decoder

Conversation

@zhhanging
Copy link
Contributor

@zhhanging zhhanging commented Nov 28, 2023

Description

Screencast

Checklist

- fix jwt-view not showing
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: jwt-decoder Issues related to the jwt-decoder extension labels Nov 28, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 28, 2023

Thank you for your first contribution! 🎉

🔔 @gdsmith you might want to have a look.

@pernielsentikaer
Copy link
Collaborator

Thanks for your contribution @zhhanging 🔥 Do you mind adding a CHANGELOG entry too?

@gdsmith can you approve this?

@pernielsentikaer pernielsentikaer self-assigned this Nov 28, 2023
- Merge branch \'contributions/merge-1701151083113667000\'
- Pull contributions
- add CHANGELOG.md
@zhhanging
Copy link
Contributor Author

I have Added a CHANGELOG.md file as suggested.

@pernielsentikaer
Copy link
Collaborator

@gdsmith are you around?

Copy link
Contributor

@gdsmith gdsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhhanging thanks so much for fixing this, I mostly use the list view so hadn't noticed this had broken. Any chance you can update the other encodeURI use as per my comment?

const dataItems = ListFromObject(data, claims);

const tokenImg = `<img alt="view token" width="720" src="data:image/svg+xml,${encodeURI(
const tokenImg = `<img alt="view token" width="720" src="data:image/svg+xml,${encodeURIComponent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another use of encodeURI in jwt-list.tsx can you replace that one too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have replaced the encodeURI in jwt-list.tsx as suggested. Thank you.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 2134a67 into raycast:main Nov 30, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/gdsmith/jwt-decoder

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@zhhanging).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@zhhanging zhhanging deleted the ext/jwt-decoder branch December 1, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: jwt-decoder Issues related to the jwt-decoder extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants