Skip to content

[Notion] Open in notion alternate action#9411

Merged
thomaslombart merged 10 commits intoraycast:mainfrom
Yakitrak:notion-open-browser
Dec 3, 2023
Merged

[Notion] Open in notion alternate action#9411
thomaslombart merged 10 commits intoraycast:mainfrom
Yakitrak:notion-open-browser

Conversation

@Yakitrak
Copy link
Contributor

@Yakitrak Yakitrak commented Nov 24, 2023

Description

Created from #9361

Adds another action to open in Notion, which is the opposite of the default open setting. e.g. If primary action is set to open in app, secondary action will open in browser and vice versa. As explained in the linked issue, I think this will be helpful to have a choice of where to open whilst still having the default a user would want.

Screencast

image

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: notion Issues related to the notion extension labels Nov 24, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 24, 2023

Thank you for your contribution! 🎉

🔔 @HenriChabrand @mathieudutour @metakirby5 @thomaslombart @erics118 @bkeys818 @AlexIsMaking you might want to have a look.

@raycastbot raycastbot added the OP is contributor The OP of the PR is a contributor of the extension label Nov 27, 2023
Copy link
Contributor

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also hide the alternate action and only show Open in Browser if a user doesn't have the Notion app installed? Otherwise, opening it will fail with an error such as this one:

CleanShot 2023-11-29 at 17 23 56@2x

@Yakitrak
Copy link
Contributor Author

Yakitrak commented Nov 29, 2023

Could you also hide the alternate action and only show Open in Browser if a user doesn't have the Notion app installed? Otherwise, opening it will fail with an error such as this one:

Good spot, thank you! Had to change the implementation slightly, but all done now 🙂

Copy link
Contributor

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@thomaslombart thomaslombart merged commit 06359e0 into raycast:main Dec 3, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/notion/notion

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@Yakitrak Yakitrak deleted the notion-open-browser branch December 4, 2023 10:43
@Yakitrak Yakitrak mentioned this pull request Dec 4, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: notion Issues related to the notion extension OP is contributor The OP of the PR is a contributor of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants