Skip to content

[Obsidian] ignore empty cache#9324

Merged
pernielsentikaer merged 1 commit intoraycast:mainfrom
KevinBatdorf:obsidian/tweak-cache-and-fix-bugs
Nov 20, 2023
Merged

[Obsidian] ignore empty cache#9324
pernielsentikaer merged 1 commit intoraycast:mainfrom
KevinBatdorf:obsidian/tweak-cache-and-fix-bugs

Conversation

@KevinBatdorf
Copy link
Contributor

Description

This PR does 3 things:

  1. If the cache is empty ([]) then ignore it
  2. If the getDefaultApplication promise rejects, it handles that properly now
  3. In the case where the user deleted the custom config location in prefs, use .obsidian

Closes #9242
Closes #9244

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: obsidian Issues related to the obsidian extension OP is author The OP of the PR is the author of the extension labels Nov 19, 2023
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 09213df into raycast:main Nov 20, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/KevinBatdorf/obsidian

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: obsidian Issues related to the obsidian extension OP is author The OP of the PR is the author of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Obsidian] Search Note failure [Obsidian] search nog working. after entering search criteria and pressing enter, this error occurs

3 participants