Skip to content

Update copyq-clipboard-manager extension#9320

Merged
raycastbot merged 6 commits intoraycast:mainfrom
andrewcincotta:ext/copyq-clipboard-manager
Dec 5, 2023
Merged

Update copyq-clipboard-manager extension#9320
raycastbot merged 6 commits intoraycast:mainfrom
andrewcincotta:ext/copyq-clipboard-manager

Conversation

@andrewcincotta
Copy link
Contributor

@andrewcincotta andrewcincotta commented Nov 19, 2023

Description

Screencast

Checklist

- Merge branch \'contributions/merge-1700357404707863000\'
- Pull contributions
- Fixed some parts of view-clipboard-entries.tsx and package.json to pass linting. Added a new screenshot to metadata Updated CHANGELOG.md
- Version 2.0! Added select-tab.tsx, a new command that allows the user to select a CopyQ tab. Completely reworked how clipboard contents are grabbed, resulting in a much faster loading time. With the rework of how clipboard contents are grabbed, preferences have been changed to allow the user to select how many clipboard entries to load.
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: copyq-clipboard-manager Issues related to the copyq-clipboard-manager extension OP is author The OP of the PR is the author of the extension labels Nov 19, 2023
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your new enhancement 🔥

When I use the commands I get a lot of crashes, check this video out:

Raycast-2hiKy0Wy.mp4

It also looks like there is some empty state flicker

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Nov 20, 2023
- Fixed portability issue with view-clipboard-entries command
- Removed more files from cache
- Added code-workspace to gitignore
- Stop tracking node_modules folder
@pernielsentikaer
Copy link
Collaborator

The new command crashes If copyq is not open, could you handle this gracefully (Maybe add a toast in both commands if possible)

copyq-clipboard-manager 2023-11-28 at 06 47 40

@andrewcincotta
Copy link
Contributor Author

The new command crashes If copyq is not open, could you handle this gracefully (Maybe add a toast in both commands if possible)

copyq-clipboard-manager 2023-11-28 at 06 47 40

I am having difficulty catching the two errors: "copyq not installed/incorrect path" and "copyq server not running". I am attempting to do try and catch, but if either of the two errors above are present, it will only show copyq path not found.

When copyq is not running, running a copyq terminal command will result in "ERROR: Cannot connect to server! Start CopyQ server first."

- Changed pictures for metadata
- Ran linter on 2 files.
- Restructured the code to use execSync instead of exec and states. Improved the speed of getting clipboard entries. Changed clipboard view to display items and markdown simultaneously. Fixed error handling for CopyQ not found and server not running.
- Ran linter on view-clipboard-entries.tsx
- Fixed clipboard entries not parsing correctly.
@pernielsentikaer
Copy link
Collaborator

I can't reproduce that error now, I guess we can continue 🚀

What about leaving the path not required and test against /opt/homebrew/bin/copyq and /usr/local/bin/copyq - if not found let the user add it in the preferences manually?

@andrewcincotta
Copy link
Contributor Author

I can't reproduce that error now, I guess we can continue 🚀

What about leaving the path not required and test against /opt/homebrew/bin/copyq and /usr/local/bin/copyq - if not found let the user add it in the preferences manually?

I'm honestly stuck on the error handling. I can't find a way to try/catch "copyq server not running" and "copyq not found". When I attempt this, my code cannot tell the difference between the two errors, and throws the same return value for each (which is why the updated error screen includes "path not found or server not running". If I could differentiate these two errors, I could check for the path better, and potentially have the extension start the copyq server if the path is found but it is not running.

If copyq is not found, it should return something like "command not found"
If copyq server is not running, it should return "ERROR: Cannot connect to server! Start CopyQ server first."

Could you assist me with this change?

@andrewcincotta
Copy link
Contributor Author

@pernielsentikaer Are we good to publish this version?

@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @andrewcincotta you might want to have a look.

@raycastbot raycastbot merged commit 388dddb into raycast:main Dec 5, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/andrewcincotta/copyq-clipboard-manager

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@andrewcincotta andrewcincotta deleted the ext/copyq-clipboard-manager branch December 10, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: copyq-clipboard-manager Issues related to the copyq-clipboard-manager extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants