Skip to content

Update ip-geolocation extension#9283

Merged
pernielsentikaer merged 1 commit intoraycast:mainfrom
frankiexyz:ext/ip-geolocation
Nov 20, 2023
Merged

Update ip-geolocation extension#9283
pernielsentikaer merged 1 commit intoraycast:mainfrom
frankiexyz:ext/ip-geolocation

Conversation

@frankiexyz
Copy link
Contributor

@frankiexyz frankiexyz commented Nov 16, 2023

Description

  • Adding IPv6 support, the existing check does not include ":" and all the IPv6 query will be marked as invalid query
  • Adding a check to use net library to valid if the user input is a valid IP address when the user input include 3 "." and no [a-z] character(indicating an IPv4 address query) or there is more than two ":" (indicating an IPv6 address query).
  • For the domain query, added a check to remove uri like https://www.foo.bar/123 becomes www.foo.bar

Screencast

Checklist

- Add IPv6 Query support and remove URI for domain query
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: ip-geolocation Issues related to the ip-geolocation extension labels Nov 16, 2023
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @koinzhang you might want to have a look.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @frankiexyz 🔥

@koinzhang do you mind checking this?

@pernielsentikaer pernielsentikaer self-assigned this Nov 17, 2023
@koinzhang
Copy link
Contributor

@pernielsentikaer I tested it briefly and I think it's okay

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 6c3bcd8 into raycast:main Nov 20, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/koinzhang/ip-geolocation

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@frankiexyz).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@frankiexyz frankiexyz deleted the ext/ip-geolocation branch November 22, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: ip-geolocation Issues related to the ip-geolocation extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants