Skip to content

Add repology-search extension#9230

Merged
raycastbot merged 7 commits intoraycast:mainfrom
sebdanielsson:ext/repology-search
Nov 17, 2023
Merged

Add repology-search extension#9230
raycastbot merged 7 commits intoraycast:mainfrom
sebdanielsson:ext/repology-search

Conversation

@sebdanielsson
Copy link
Contributor

@sebdanielsson sebdanielsson commented Nov 13, 2023

Description

Add Repology Search extension. It let's you search packages on repology.org.

Screencast

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Nov 13, 2023
@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • The extension crashes when you search for git

repology-search 2023-11-14 at 05 34 41

  • Show Details action is missing an icon

repology-search 2023-11-14 at 05 35 18

  • The initial empty has a weird working since I didn't search yet

repology-search 2023-11-14 at 05 35 54

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Nov 14, 2023
@sebdanielsson
Copy link
Contributor Author

@pernielsentikaer thanks for the review. These issues should be resolved now! :)

@pernielsentikaer
Copy link
Collaborator

If I search for git and delete the query again, then I'm stuck with the list, maybe we should clear it when query length is back to 2 again?

@sebdanielsson
Copy link
Contributor Author

If I search for git and delete the query again, then I'm stuck with the list, maybe we should clear it when query length is back to 2 again?

Good idea! Please try again. The results should be cleared now. :)

@pernielsentikaer
Copy link
Collaborator

Works much better! 🔥

A few small things:

  • Maybe you can use throttle and skip the debounce completely. I'm not sure if that makes sense.

  • Is there a reason why it doesn't search from the first character?

@sebdanielsson
Copy link
Contributor Author

Using throttling now!😃 Also added sorting to the repo filter. I added the minimum of two characters to not send unnecessary API calls because no package is shorter than two chars.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋

Everything looks great to me. Approved! 🔥

Thank you for your cooperation 🚀

@raycastbot raycastbot merged commit 331f188 into raycast:main Nov 17, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/SebDanielsson/repology-search

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@sebdanielsson
Copy link
Contributor Author

Hi there! 👋

Everything looks great to me. Approved! 🔥

Thank you for your cooperation 🚀

Thank you for the guidance. Learned a lot!😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new extension Label for PRs with new extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants