fix(notion): error when opening page created from form#9182
Merged
thomaslombart merged 2 commits intoraycast:mainfrom Nov 13, 2023
Merged
fix(notion): error when opening page created from form#9182thomaslombart merged 2 commits intoraycast:mainfrom
thomaslombart merged 2 commits intoraycast:mainfrom
Conversation
Collaborator
|
Thank you for your contribution! 🎉 🔔 @HenriChabrand @mathieudutour @metakirby5 @thomaslombart @bkeys818 @AlexIsMaking you might want to have a look. |
78e0f56 to
7c19146
Compare
erics118
commented
Nov 9, 2023
| title: "Open Page", | ||
| shortcut: { modifiers: ["cmd"], key: "o" }, | ||
| onAction: () => handleOnOpenPage(page, useRecentPages().setRecentPage), | ||
| onAction: () => handleOnOpenPage(page, setRecentPage), |
Contributor
Author
There was a problem hiding this comment.
The original error was that it broke the Rule of Hooks. Originally, useRecentPages (a hook) was called inside a function. Fix was just to call useRecentPages inside the component
Collaborator
|
Published to the Raycast Store: |
Collaborator
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes the error when trying to open a a page that was just created from the
Create Database PagecommandFix #9152
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder