Skip to content

fix: incorrect .dismiss path leading to perpetually ringing timer#9149

Merged
pernielsentikaer merged 1 commit intoraycast:mainfrom
ThatNerdSquared:critical-timers-update
Nov 8, 2023
Merged

fix: incorrect .dismiss path leading to perpetually ringing timer#9149
pernielsentikaer merged 1 commit intoraycast:mainfrom
ThatNerdSquared:critical-timers-update

Conversation

@ThatNerdSquared
Copy link
Contributor

Description

In my last PR, I made a small change to the function that handles stopping timers - unfortunately, this led to a bug where the timer alert would ring perpetually even after the timer had been stopped. This was because of an incorrect .dismiss path that led to that file never being deleted. Thanks to @atuooo for catching this.

@atuooo has not been added to the contributors field in the package.json yet, but as this is an extremely annoying regression for users, I'd like to merge this PR as soon as possible. If needed, we can file another PR later to update the contributors list.

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: timers Issues related to the timers extension OP is author The OP of the PR is the author of the extension labels Nov 8, 2023
@pernielsentikaer pernielsentikaer merged commit d2dd5c4 into raycast:main Nov 8, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/ThatNerd/timers

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@ThatNerdSquared ThatNerdSquared deleted the critical-timers-update branch November 8, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: timers Issues related to the timers extension OP is author The OP of the PR is the author of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants