fix: incorrect .dismiss path leading to perpetually ringing timer#9149
Merged
pernielsentikaer merged 1 commit intoraycast:mainfrom Nov 8, 2023
Merged
Conversation
Collaborator
|
Published to the Raycast Store: |
Collaborator
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In my last PR, I made a small change to the function that handles stopping timers - unfortunately, this led to a bug where the timer alert would ring perpetually even after the timer had been stopped. This was because of an incorrect
.dismisspath that led to that file never being deleted. Thanks to @atuooo for catching this.@atuooo has not been added to the contributors field in the
package.json yet, but as this is an extremely annoying regression for users, I'd like to merge this PR as soon as possible. If needed, we can file another PR later to update the contributors list.Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder