Conversation
- make it public - Removed old screenshots - Zipper extension v1 - Zipper extension v1 - Initial commit
|
Congratulation on your new Raycast extension! 🚀 We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store. |
- Readme - moving to metadata folder - zipper run screenshot
- Changed any to unkown - Fixed sizes in metadata screenshots - Command title to be cased - make it private
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Thanks for your contribution 💪
I have now tested your extension, and I have some feedback ready for you:
-
Missing a loading indicator
-
The push is not an ideal solution since if you hit escape once you’ll end in a blank window.
You can maybe do some conditional returns instead like:
function Command() {
const token. = something();
if (!something) {
return <Form>{…}</Form>
} else {
return <List>{…}</List>
}
}
- Would it make sense to make a list view with either scripts returned by an API OR let the user add them themselves, I can see that it might be a hard job remembering the name and file
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.
|
Hi @pernielsentikaer |
pernielsentikaer
left a comment
There was a problem hiding this comment.
I think we're almost there. If you try to fetch something that's not working, it never stops loading. Could you look into that?
- Merge branch \'contributions/merge-1699885878134657000\' - Pull contributions - added error handling
|
@pernielsentikaer I've added the error handling. You can re-review |
|
hi @pernielsentikaer |
|
There is a small empty state flicker when I search for |
|
@pernielsentikaer can you provide me with a more clear example of when this is happening so I can check? |
|
It might be hard to see but if you look right before data is returned it shows "No Results" - I'm not sure how easy it is to do something - I can also try if you don't have an idea 🙂 Raycast-wTyKe3Yq.mp4 |
|
@pernielsentikaer is it possible to be some issue with the List component? |
|
It seems like we have an error as you said, thanks for pointing it out - we'll address that in the next release and will not be a blocker now 🙂 |
|
You are welcome. |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
No, everything should be fine now 🔥 Thanks for your cooperation. It was a pleasure working with you 🙂 |
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder