[Espanso]: Add ability to display match labels to Search Matches command by nbbaier · Pull Request #9101 · raycast/extensions

nbbaier · 2023-11-04T00:04:18Z

Description

Changes the method of getting matches for the Search Matches command, directly checking YAML files instead of using Espanso's shell command
Introduces the ability to display labels in search results and therefore resolves [Espanso] Copies "Label" field instead of "Replace" field. #8235 (labels overriding the replace of an Espanso match).
Improves the fetching of matches and match files, accounting for potential differences in configs that was not there before

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- added 'Toggle Espanso' command' - added 'Add Match' command - added commands to manifest - added action to paste snippet to front application - extracted types, messages from index.tsx - add utils.ts

- added function to get matches to replace call to espanso match exec -j - added some types - added the ability to display label in search

raycastbot · 2023-11-04T00:07:19Z

Thank you for your contribution! 🎉

🔔 @kud you might want to have a look.

dependencies.

pernielsentikaer · 2023-11-04T07:42:22Z

@nbbaier thanks for your contribution 🔥 Do you mind adding a CHANGELOG entry 🙂

@kud do you mind checking this 🙂

nbbaier · 2023-11-04T16:19:27Z

@nbbaier thanks for your contribution 🔥 Do you mind adding a CHANGELOG entry 🙂

Done!

kud · 2023-11-04T21:33:29Z

Hey, thanks for the PR. Could you please update the title of the PR to make it meaningful? 🙏

Regarding the PR itself, to understand it better, instead of using the shell command, are you checking the espanso YAML files? It seems legitimate to me. However, I didn't notice initially that the previous PR added "Add match," but it's broken. The issue lies in assuming that people use the default folders. For some reason that I haven't explained (maybe a legacy one), I don't use them, but I use ~/Library/Preferences/espanso.

I will change it to use the default ones now.

However, this means that the code is not secure enough. Could you please use something like espanso path to determine the location of the config? It would be safer. (Unless you know a better way to find the config files). Thanks.

nbbaier · 2023-11-05T00:23:58Z

Hey, thanks for the PR. Could you please update the title of the PR to make it meaningful? 🙏

Done!

Regarding the PR itself, to understand it better, instead of using the shell command, are you checking the espanso YAML files? It seems legitimate to me.

Yes, exactly. I intended this both as a method to get the labels from the YAML files and to also allow for future addition of the displaying of variables in the list item detail view (since neither variables, forms, labels, etc are returned by espanso match list -j.

However, I didn't notice initially that the previous PR added "Add match," but it's broken. The issue lies in assuming that people use the default folders. For some reason that I haven't explained (maybe a legacy one), I don't use them, but I use ~/Library/Preferences/espanso. However, this means that the code is not secure enough. Could you please use something like espanso path to determine the location of the config? It would be safer. (Unless you know a better way to find the config files). Thanks.

Will do! I forgot about espanso path and this will be a nice way to do it.

nbbaier · 2023-11-05T03:34:55Z

@kud, those fixes have been made

extensions/espanso/src/addMatch.tsx

extensions/espanso/src/index.tsx

extensions/espanso/src/utils.ts

ind

kud · 2023-11-09T19:31:26Z

Thanks. It's really neat now!

nbbaier · 2023-11-09T19:33:57Z

Thanks. It's really neat now!

Thanks for your suggestions! Still getting the hang of writing neat code haha

kud · 2023-11-09T19:47:52Z

Hehe congrats!

pernielsentikaer · 2023-11-10T06:19:27Z

Thanks for handling @kud, and thanks @nbbaier for the enhancement

pernielsentikaer

Hi 👋

Looks good to me, approved 🔥

raycastbot · 2023-11-10T06:31:19Z

Published to the Raycast Store:
https://raycast.com/kud/espanso

raycastbot · 2023-11-10T06:31:22Z

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

nbbaier and others added 4 commits July 18, 2023 20:57

Update espanso extension

e0a49fb

- added 'Toggle Espanso' command' - added 'Add Match' command - added commands to manifest - added action to paste snippet to front application - extracted types, messages from index.tsx - add utils.ts

Update package.json

9e671a6

Changelog entry

13958c5

Update espanso extension

dc2d0b1

- added function to get matches to replace call to espanso match exec -j - added some types - added the ability to display label in search

raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: espanso Issues related to the espanso extension OP is contributor The OP of the PR is a contributor of the extension labels Nov 4, 2023

nbbaier added 5 commits November 3, 2023 19:11

Merge branch 'main' into ext/espanso

6e745c6

Remove unused const

b9f709a

removed empty line

8de3f20

edited imports

cc3c5ce

Refactor Espanso extension code and update

89ca618

dependencies.

pernielsentikaer self-assigned this Nov 4, 2023

Improve search matches and fix display bug

1b2deb5

nbbaier changed the title ~~Update espanso extension~~ [Espanso]: Add ability to display match labels to Search Matches command Nov 5, 2023

nbbaier added 7 commits November 4, 2023 22:24

Fix package.json formatting.

291c0fa

Improved method of getting match files and error handling

f4c725d

updated formatting

27c79e4

Updated method of fetching matches

ef630e8

Add error handling to Espanso toggle command

9d3a3c1

Add EspansoConfig type

f11a796

Added getEspansoConfig(), improved getMatches()

48728d1

kud suggested changes Nov 6, 2023

View reviewed changes

extensions/espanso/src/addMatch.tsx Outdated Show resolved Hide resolved

extensions/espanso/src/addMatch.tsx Outdated Show resolved Hide resolved

extensions/espanso/src/index.tsx Outdated Show resolved Hide resolved

extensions/espanso/src/utils.ts Outdated Show resolved Hide resolved

pernielsentikaer added the status: awaiting response from dev label Nov 7, 2023

kud approved these changes Nov 9, 2023

View reviewed changes

refactor(index.tsx): change to avoid mutating variables

cf49124

ind

nbbaier mentioned this pull request Nov 9, 2023

[Espanso] Improvements to match match insertion #9184

Closed

pernielsentikaer approved these changes Nov 10, 2023

View reviewed changes

pernielsentikaer merged commit 534ff84 into raycast:main Nov 10, 2023

Conversation

nbbaier commented Nov 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screencast

Checklist

Uh oh!

raycastbot commented Nov 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pernielsentikaer commented Nov 4, 2023

Uh oh!

nbbaier commented Nov 4, 2023

Uh oh!

kud commented Nov 4, 2023

Uh oh!

nbbaier commented Nov 5, 2023

Uh oh!

nbbaier commented Nov 5, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kud commented Nov 9, 2023

Uh oh!

nbbaier commented Nov 9, 2023

Uh oh!

kud commented Nov 9, 2023

Uh oh!

pernielsentikaer commented Nov 10, 2023

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

raycastbot commented Nov 10, 2023

Uh oh!

raycastbot commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nbbaier commented Nov 4, 2023 •

edited

Loading

raycastbot commented Nov 4, 2023 •

edited

Loading