Skip to content

feat(vault): add oidc login method#9090

Merged
pernielsentikaer merged 3 commits intoraycast:mainfrom
fonimus:vault-oidc-login
Nov 4, 2023
Merged

feat(vault): add oidc login method#9090
pernielsentikaer merged 3 commits intoraycast:mainfrom
fonimus:vault-oidc-login

Conversation

@fonimus
Copy link
Contributor

@fonimus fonimus commented Nov 3, 2023

Description

Add new login method : OIDC

Screencast

Capture d’écran 2023-11-03 à 11 33 57

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: vault Issues related to the vault extension OP is author The OP of the PR is the author of the extension labels Nov 3, 2023
@pernielsentikaer
Copy link
Collaborator

Hi @fonimus 👋

Is this change better than the previous one that we need to set the new auth provider?

Could you also add a CHANGELOG entry

@pernielsentikaer pernielsentikaer self-assigned this Nov 3, 2023
@fonimus
Copy link
Contributor Author

fonimus commented Nov 3, 2023

Hi @fonimus 👋

Is this change better than the previous one that we need to set the new auth provider?

Could you also add a CHANGELOG entry

Hello @pernielsentikaer, this change is better in my opinion because the OIDC method does not need any other information (token needs the token to be set, ldap needs user/pwd to be set). OIDC information are stored in vault and an enpoint allow us to get all we need to perform oauth login.

For existing users, as it is stored in preferences, there will not be any impacts.

Changelog updated, thanks for the reminder ;)

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit fda4572 into raycast:main Nov 4, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/fonimus/vault-manager

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: vault Issues related to the vault extension OP is author The OP of the PR is the author of the extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants