[Simple Reminder]: fix word eating#9026
Merged
pernielsentikaer merged 6 commits intoraycast:mainfrom Oct 31, 2023
Merged
Conversation
Collaborator
Contributor
Author
pernielsentikaer
approved these changes
Oct 31, 2023
Collaborator
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
Collaborator
|
Thank you for your contribution! 🎉 🔔 @comoser you might want to have a look. |
Collaborator
|
Published to the Raycast Store: |
Collaborator
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR to fix part of the issue #8990. The extension will no longer cut individual words, instead, it will cut certain expressions, like "remind me to" from the topic to be reminded about.
The "time and date" word tokens will also be removed from the equation, which hopefully will output the topics as the users intend.
Regarding the special characters that exist for instance in german, the extension doesn't support any other language other than english since it uses a natural language processor for english only. There's no current plans to support other languages now as that would be too much of an effort.
The extension still supports other languages of course, but with limitations.
Closes #8990
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder