Conversation
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Thanks for your contribution 💪
I have now tested your extension, and I have some feedback ready for you
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.
| if (response.type === "error") { | ||
| await showFailureToast(response.message, { title: response.code }); | ||
| } else { | ||
| await showToast(Toast.Style.Success, "SUCCESS", `Credit: ${response.result.credit}`); |
There was a problem hiding this comment.
I would use updateCommandMetadata instead, and maybe add an interval to the call so it updates, for example, every hour.
There was a problem hiding this comment.
purelymail-check-account-credit.mp4
Hi 👋 .
This is a great suggestion! I have implemented as shown in attached video.
Best 👍🏽 .
There was a problem hiding this comment.
Do you think it makes sense to round the number, there is a lot of decimals going on there 🙂
There was a problem hiding this comment.
It's a reasonable suggestion which I've implemented and also updated the metadata screenshot accordingly;
| } else { | ||
| const { credit } = response.result; | ||
| const roundedCredit = parseFloat(credit as string).toFixed(2); | ||
| await Clipboard.copy(roundedCredit); |
There was a problem hiding this comment.
Does it make sense to copy to the clipboard? I would maybe not do that since that's unexpected behavior. 😊
There was a problem hiding this comment.
I can follow that logic.
Updated so that:
- Credit is shown as formatted currency since that is how it is shown in Purelymail Billing AND
- No longer copied to Clipboard.
|
Thank you for your contribution! 🎉 🔔 @xmok you might want to have a look. |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
[Added Billing and App Password Endpoints]
Enhancements
viewtono-viewNew Endpoints
Screencast
purelymail-screencast-1.mp4
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolderNote to reviewers
Purelymailwas the first extension I added so some of the code is inefficient which I hope to address in future versions.