Skip to content

Update whois extension#8853

Merged
pernielsentikaer merged 2 commits intoraycast:mainfrom
solid-pixel:ext/whois
Oct 18, 2023
Merged

Update whois extension#8853
pernielsentikaer merged 2 commits intoraycast:mainfrom
solid-pixel:ext/whois

Conversation

@solid-pixel
Copy link
Contributor

@solid-pixel solid-pixel commented Oct 18, 2023

Description

Hello @zavbala !

This PR adds the ability to query IP addresses too.

I've had to rely on https://ipwho.is for IP addresses only because https://scraper.run/ip?addr= was returning very little data and it was all useless.

There's been quite a lot of refactoring involved but here's an overview of what's been done:

  • Added ability to handle both domain names and IP addresses as inputs.
  • Made WHOIS in the response clickable, which will take the user to who.is
  • Added a placeholder in the input field to indicate the ability to input either a domain or an IP address.
  • Improved error handling to catch and log issues during the data fetching process.
  • Updated the regular expression used to determine if the input is a domain to also allow subdomains.
  • Adjusted the way input is obtained from props to directly access the arguments object.
  • Refactored the fetcher function to handle data from both domain and IP lookups and render them appropriately in markdown format.

I've tested this quite thoroughly and it seems to be working perfectly but feel free to test it too :)

Screen.Recording.2023-10-18.at.13.39.41.mov

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: zavbala/whois Issues related to the zavbala/whois extension labels Oct 18, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 18, 2023

Thank you for your contribution! 🎉

🔔 @zavbala @snilan you might want to have a look.

@pernielsentikaer
Copy link
Collaborator

I gave it a spin and it works as expected for me 🔥

@zavbala could you check this 🙂

@pernielsentikaer pernielsentikaer self-assigned this Oct 18, 2023
@zavbala
Copy link
Contributor

zavbala commented Oct 18, 2023

I love it, I really do, go ahead, now the extension is stronger 🤩

@pernielsentikaer pernielsentikaer merged commit 140f2e9 into raycast:main Oct 18, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/zavbala/whois

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: zavbala/whois Issues related to the zavbala/whois extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants