Skip to content

feat: year progress add copy to clipboard#8849

Merged
pernielsentikaer merged 4 commits intoraycast:mainfrom
chenpx976:feat-cpx-progress-copy
Oct 18, 2023
Merged

feat: year progress add copy to clipboard#8849
pernielsentikaer merged 4 commits intoraycast:mainfrom
chenpx976:feat-cpx-progress-copy

Conversation

@chenpx976
Copy link
Contributor

@chenpx976 chenpx976 commented Oct 18, 2023

Description

year progress add copy to clipboard

Screencast

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: thomas/year-in-progress Issues related to the thomas/year-in-progress extension labels Oct 18, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 18, 2023 •
edited
Loading

Thank you for your contribution! 🎉

🔔 @thomaspaulmann @danulqua @anothertempore you might want to have a look.

@anothertempore
Copy link
Contributor

anothertempore commented Oct 18, 2023

LGTM!

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 18, 2023

Hi @chenpx976! 👋

Thank you for the enhancement. It works as expected. 🙂

I'm not sure if the UX is the best. Maybe we should introduce a preference value to determine whether it should be copied to the clipboard or not. Currently, the action in the action panel only says "refresh."

WDYT?

@pernielsentikaer pernielsentikaer self-assigned this Oct 18, 2023
@chenpx976
Copy link
Contributor Author

chenpx976 commented Oct 18, 2023

@pernielsentikaer
You're right, I've modified the copied action placed in the action of x-in-progress

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 18, 2023

Could you as the last thing add a CHANGELOG entry? 🙂

pernielsentikaer
pernielsentikaer approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit dd37a3b into raycast:main Oct 18, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 18, 2023

Published to the Raycast Store:
https://raycast.com/thomas/year-in-progress

@raycastbot
Copy link
Collaborator

raycastbot commented Oct 18, 2023

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@chenpx976 chenpx976 deleted the feat-cpx-progress-copy branch October 18, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pernielsentikaer pernielsentikaer pernielsentikaer approved these changes

@thomaspaulmann thomaspaulmann Awaiting requested review from thomaspaulmann thomaspaulmann is a code owner

Assignees

@pernielsentikaer pernielsentikaer

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: thomas/year-in-progress Issues related to the thomas/year-in-progress extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenpx976 @raycastbot @anothertempore @pernielsentikaer