Skip to content

Update ffmpeg extension#8847

Merged
pernielsentikaer merged 3 commits intoraycast:mainfrom
aagedal:ext/ffmpeg
Nov 16, 2023
Merged

Update ffmpeg extension#8847
pernielsentikaer merged 3 commits intoraycast:mainfrom
aagedal:ext/ffmpeg

Conversation

@aagedal
Copy link

@aagedal aagedal commented Oct 17, 2023

Description

– I added a new video file conversion option, called VideoLoop Converter. This uses FFMPEG to create a h.264 .mp4 file without sound, at a bitrate of 4000kbps. This is intended to be used as a replacement for GIFs on certain websites.
– Changed the progress view so that the feedback is in percentage, rather than a float between 0 and 1.
– Fixed an issue that prevented processing (rotation/conversion) of files that has spaces in the path.
– Changed version number to 1.1.0, from 1.0.0

Screencast

Checklist

Truls Aagedal added 2 commits October 17, 2023 22:48
…ith 1080p on the short side automatically removing sound. This is intended as a gif-replacementfor certain websites. Also fixed a bug that would prevent rotation (conversion) when using input files containing spaces in path.
…ter. This uses FFMPEG to create a h.264 .mp4 file without sound, at a bitrate of 4000kbps. This is intended to be used as a replacement for GIFs on certain websites. – Changed the progress view so that the feedback is in percentage, rather than a float between 0 and 1. – Fixed an issue that prevented processing (rotation/conversion) of files that has spaces in the path. – Changed version number to 1.1.0, from 1.0.0
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: RenderCoder/ffmpeg Issues related to the RenderCoder/ffmpeg extension labels Oct 17, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 17, 2023

Thank you for your contribution! 🎉

🔔 @RenderCoder @blekmus you might want to have a look.

@pernielsentikaer
Copy link
Collaborator

Hi @ratocx 👋

Thanks for the update 🔥 Could you also update Prettier to version 3.0.3 and resolve the conflicts?

Let me know if you need any help doing so 🙂

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Oct 18, 2023
- Fixed code style errors with Prettier. (Hopefully)
- – I added a new video file conversion option, called VideoLoop Converter. This uses FFMPEG to create a h.264 .mp4 file without sound, at a bitrate of 4000kbps. This is intended to be used as a replacement for GIFs on certain websites. – Changed the progress view so that the feedback is in percentage, rather than a float between 0 and 1. – Fixed an issue that prevented processing (rotation/conversion) of files that has spaces in the path. – Changed version number to 1.1.0, from 1.0.0 - Fixed code style issues with Prettier (hopefully)
- – I added a new video file conversion option, called VideoLoop Converter. This uses FFMPEG to create a h.264 .mp4 file without sound, at a bitrate of 4000kbps. This is intended to be used as a replacement for GIFs on certain websites. – Changed the progress view so that the feedback is in percentage, rather than a float between 0 and 1. – Fixed an issue that prevented processing (rotation/conversion) of files that has spaces in the path. – Changed version number to 1.1.0, from 1.0.0 - Fixed code formatting issues from previous commit attempt. (Hopefully)
- – I added a new video file conversion option, called VideoLoop Converter. This uses FFMPEG to create a h.264 .mp4 file without sound, at a bitrate of 4000kbps. This is intended to be used as a replacement for GIFs on certain websites. – Changed the progress view so that the feedback is in percentage, rather than a float between 0 and 1. – Fixed an issue that prevented processing (rotation/conversion) of files that has spaces in the path. – Changed version number to 1.1.0, from 1.0.0
@aagedal
Copy link
Author

aagedal commented Oct 21, 2023

Hopefully the code style is fixed now.
Moved to VSCode with Prettier, and turned on automatic formatting on save, so hopefully this problem shouldn't occur anymore. :)

@pernielsentikaer
Copy link
Collaborator

@RenderCoder @blekmus do you mind checking this?

@blekmus
Copy link
Contributor

blekmus commented Oct 26, 2023

@pernielsentikaer I'm having trouble cloning this. I want to test this out locally, how should I proceed with it?
I tried running npx @raycast/api@latest pull-contributions and that didn't work.

@pernielsentikaer
Copy link
Collaborator

You should be able to checkout raycast/extensions and run gh pr checkout 8847 - we're looking into a way to make this faster

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Nov 13, 2023
@blekmus
Copy link
Contributor

blekmus commented Nov 16, 2023

That's pretty much it. Everything checks out and works as expected

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Nov 16, 2023
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 136b10d into raycast:main Nov 16, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/RenderCoder/ffmpeg

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@aagedal).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: RenderCoder/ffmpeg Issues related to the RenderCoder/ffmpeg extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants