Skip to content

Ext/material icons#8793

Merged
raycastbot merged 9 commits intoraycast:mainfrom
201549BL:ext/material-icons
Nov 15, 2023
Merged

Ext/material icons#8793
raycastbot merged 9 commits intoraycast:mainfrom
201549BL:ext/material-icons

Conversation

@201549BL
Copy link
Contributor

@201549BL 201549BL commented Oct 13, 2023 •
edited
Loading

Description

Added a Grid view to the extension.

I left the original list view per this comment in case there would be any conflicts with PR #8761.

Screencast

Raycast 2023-10-13 at 10 27 58 Raycast-2 Raycast-3 Raycast-4

Checklist

@201549BL
Grid view, remove readme, screenshots, changelog
6bc2195
@201549BL
Update material-icons extension
1862d78 
- Grid view, remove readme, screenshots, changelog
- Grid view, remove readme, screenshots, changelog
@201549BL
Merge branch 'raycast:main' into ext/material-icons
ff63a1c
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: creasty/material-icons Issues related to the creasty/material-icons extension labels Oct 13, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 13, 2023 •
edited
Loading

Thank you for your contribution! 🎉

🔔 @creasty @3llomi you might want to have a look.

@201549BL 201549BL mentioned this pull request Oct 13, 2023
Closed
5 tasks
@pernielsentikaer pernielsentikaer self-assigned this Oct 17, 2023
pernielsentikaer
pernielsentikaer requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • It would be better to have just one command and make it possible to change the view with a preference instead.

  • There are some CI errors and merge conflicts. Can you resolve them too?

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 18, 2023

Should we consider using the same colors for the icons in both views? For me, black/white would make sense 🙂

Could you look into this @201549BL?

@creasty could you look into this 🙂

@201549BL
Copy link
Contributor Author

201549BL commented Oct 18, 2023

@pernielsentikaer

I agree. In "grid view" I'm using tintColor: Color.PrimaryText to make the icons contrast from the background. But I can definitely make them black/white for both the "list view" and "grid view" if that is preferred?

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 18, 2023

I think that would be the best way here yes 🙂

@201549BL
icon color, screenshots
9212ec4 
Made the icon color either black or white depending on raycast theme.

Updated screenshots to match the icon colors.
@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 18, 2023

Awesome, then we just need @creasty do have a look 🙂

@raycastbot
Copy link
Collaborator

raycastbot commented Nov 1, 2023

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Nov 1, 2023
@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Nov 1, 2023

Pinging @creasty one more time

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Nov 1, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 15, 2023

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Nov 15, 2023
@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Nov 15, 2023
pernielsentikaer
pernielsentikaer approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot added the extension: material-icons Issues related to the material-icons extension label Nov 15, 2023
@raycastbot raycastbot merged commit 9579da9 into raycast:main Nov 15, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 15, 2023

Published to the Raycast Store:
https://raycast.com/creasty/material-icons

@raycastbot
Copy link
Collaborator

raycastbot commented Nov 15, 2023

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@201549BL 201549BL deleted the ext/material-icons branch November 15, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pernielsentikaer pernielsentikaer pernielsentikaer approved these changes

Assignees

@pernielsentikaer pernielsentikaer

Labels

extension: creasty/material-icons Issues related to the creasty/material-icons extension extension fix / improvement Label for PRs with extension's fix improvements extension: material-icons Issues related to the material-icons extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@201549BL @raycastbot @pernielsentikaer