Skip to content

[GitHub] Various search usability improvements#8786

Merged
thomaslombart merged 8 commits intoraycast:mainfrom
peppy:ext/github/search-improvements
Oct 23, 2023
Merged

[GitHub] Various search usability improvements#8786
thomaslombart merged 8 commits intoraycast:mainfrom
peppy:ext/github/search-improvements

Conversation

@peppy
Copy link
Contributor

@peppy peppy commented Oct 12, 2023

I have been using raycast as a primary means of searching github more recently, and made some improvements to improve productivity when doing so. I believe these can be useful to other users apart from me.

Description

Add "search discussions" command (92cad57)

This was one missing command. Until now we only had "My Discussions" which didn't allow searching globally.

2023-10-13.05.29.09.mp4

I'd probably also suggest renaming "Open issues" to "My issues" to match the other commands that are author:@me filtered.

Add dropdown to choose target repositories when searching issues, PRs and discussions (e80bfd5)

There was already a dropdown component allowing to choose <global|user|org> scope when searching repositories. I have added this dropdown to issue, pull request and discussion search commands.

2023-10-13.05.30.30.mp4

Add customisation of result count (8668c35)

The default result count was 50, which can be quite low (server-side). I've been using 6-10 for my own purposes, which provides magnitudes faster responses from github.

2023-10-13.05.32.07.mp4

Note the loading time difference in the video between 50 and 5 results.

Add default search term text (b5f017d)

This is a bit of an advanced use case, but I generally have some default criteria which I want to be pre-populated in the search box. If I don't need them, removing is just one opt-delete away. This can, for instance, allow for a default sort to be added, or any other supported github search criteria.

2023-10-13.05.34.13.mp4

Closes #8052.

Checklist

@raycastbot
Copy link
Collaborator

raycastbot commented Oct 12, 2023

Thank you for your first contribution! 🎉

🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo you might want to have a look.

Copy link
Contributor

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the CI errors? Otherwise, looks good to me 🚀

@peppy
Copy link
Contributor Author

peppy commented Oct 23, 2023

Thanks for reviewing the changes.

Error: 19:4 error Invalid contributor "peppy". Error: Not found (RequestID: 69961326-6336-44d4-8e04-449a5e6f6077)

I'm not too sure about this one, am I not supposed to add myself here? 😅

@thomaslombart
Copy link
Contributor

@peppy Is peppy your actual Raycast account? It seems not according to this page: https://www.raycast.com/peppy.

@peppy
Copy link
Contributor Author

peppy commented Oct 23, 2023

Aha, I guess it's ppy https://www.raycast.com/ppy, thanks!

@thomaslombart thomaslombart merged commit 75ae2a3 into raycast:main Oct 23, 2023
@thomaslombart
Copy link
Contributor

Merged, thanks for the contribution! 🔥

@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/raycast/github

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username.
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@Angelk90
Copy link

@peppy : Can you see if for the workflows you can only see yours, not the cloned ones?

@peppy
Copy link
Contributor Author

peppy commented Oct 23, 2023

@peppy : Can you see if for the workflows you can only see yours, not the cloned ones?

I'm not too clear what you mean, could you explain a bit more?

@Angelk90
Copy link

@peppy : If you go to Workflow Runs, do you see the cloned projects in the selection menu?
Or you only see your personal projects, created by you (whether they are private or public does not change).

P.s.

Are you on the Raycast Slack channel?

If so we can talk about it there.

@peppy
Copy link
Contributor Author

peppy commented Oct 23, 2023

I'd recommend opening a new issue for discussion, as this doesn't sound related to the change I've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GitHub] Search Issues implies it searches globally but actually only searches own

4 participants