[1Password] Use Clipboard.copy(..., {concealed: true}) to copy a password#8641
Merged
pernielsentikaer merged 1 commit intomainfrom Oct 5, 2023
Merged
[1Password] Use Clipboard.copy(..., {concealed: true}) to copy a password#8641pernielsentikaer merged 1 commit intomainfrom
Clipboard.copy(..., {concealed: true}) to copy a password#8641pernielsentikaer merged 1 commit intomainfrom
Conversation
Collaborator
|
Thank you for your contribution! 🎉 🔔 @khasbilegt @thomaspaulmann @dteare @pernielsentikaer @cb372 @Davidwalser @henrik-dmg @justspacedog you might want to have a look. |
pernielsentikaer
approved these changes
Oct 5, 2023
Collaborator
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
Collaborator
|
Published to the Raycast Store: |
Collaborator
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There should be no functionality changes, this PR only avoids sending the password in plain text to AppleScript and instead uses the new
concealedoption to copy itChecklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder