Skip to content

Update douban extension#8590

Merged
pernielsentikaer merged 9 commits intoraycast:mainfrom
iiwenwen:ext/douban
Oct 23, 2023
Merged

Update douban extension#8590
pernielsentikaer merged 9 commits intoraycast:mainfrom
iiwenwen:ext/douban

Conversation

@iiwenwen
Copy link
Contributor

@iiwenwen iiwenwen commented Sep 27, 2023

Description

Screencast

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: crazyczy/douban Issues related to the crazyczy/douban extension labels Sep 27, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Sep 27, 2023

Thank you for your contribution! 🎉

🔔 @crazyczy you might want to have a look.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${user.title}(豆瓣)](${user.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello,recovered.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${site.title}(豆瓣)](${site.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${music.title}(豆瓣)](${music.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${movie.title}(豆瓣)](${movie.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${group.title}(豆瓣)](${group.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${game.title}(豆瓣)](${game.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

/>
<Action.CopyToClipboard
title="Copy As Markdown"
content={`[${book.title}(豆瓣)](${book.url})`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, Raycast doesn't support localization and only supports US English. Therefore, please avoid introducing your custom way to localize your extension.

@pernielsentikaer
Copy link
Collaborator

Hi @iiwenwen 👋

Thanks for your contribution 🔥 Could you add a CHANGELOG entry too?

@crazyczy could you check this

@pernielsentikaer pernielsentikaer self-assigned this Oct 10, 2023
@iiwenwen
Copy link
Contributor Author

@pernielsentikaer I add CHANGELOG.

@crazyczy
Copy link
Contributor

LGTM!

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be an idea to make some components that the commands are using? Seems like most of the code is just duplicated. 🙂

@iiwenwen
Copy link
Contributor Author

@pernielsentikaer I’m sorry, I’m not a programmer. I can’t do what you said for the time being. I want to know, is there any other problem with this PR? There is still no merger.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit c16c4bc into raycast:main Oct 23, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/crazyczy/douban

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: crazyczy/douban Issues related to the crazyczy/douban extension extension fix / improvement Label for PRs with extension's fix improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants