Skip to content

[Bugfix] [Network Speed] Fix no loading animation#8589

Merged
raycastbot merged 4 commits intoraycast:mainfrom
koinzhang:bugfix/network-speed/fix-render-issue
Oct 10, 2023
Merged

[Bugfix] [Network Speed] Fix no loading animation#8589
raycastbot merged 4 commits intoraycast:mainfrom
koinzhang:bugfix/network-speed/fix-render-issue

Conversation

@koinzhang
Copy link
Contributor

@koinzhang koinzhang commented Sep 27, 2023 •
edited
Loading

Description

  • Add information display during speed measurement

Screencast

Screencast.mp4

Checklist

@koinzhang koinzhang force-pushed the bugfix/network-speed/fix-render-issue branch from 3243d33 to 3e09d07 Compare September 27, 2023 07:38
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: koinzhang/network-speed Issues related to the koinzhang/network-speed extension OP is author The OP of the PR is the author of the extension labels Sep 27, 2023
@koinzhang koinzhang force-pushed the bugfix/network-speed/fix-render-issue branch from 3e09d07 to 73420fd Compare September 27, 2023 11:30
@koinzhang koinzhang force-pushed the bugfix/network-speed/fix-render-issue branch from 73420fd to 5cc157f Compare October 2, 2023 11:49
@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 4, 2023

I don't see anything else than this when running it 🫠

Raycast-wbBrwc0i

@pernielsentikaer pernielsentikaer self-assigned this Oct 4, 2023
@koinzhang
Copy link
Contributor Author

koinzhang commented Oct 6, 2023

Hi @pernielsentikaer, must be upgraded to the latest sonoma to display the data during the measurement. Which Mac system version do you have?
I just submitted a commit to add placeholder characters for a lower version of the system.

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 9, 2023

Which Mac system version do you have?

I'm on Sonoma 14.1 Beta (23B5056e)

@koinzhang
Copy link
Contributor Author

koinzhang commented Oct 9, 2023

Sonoma is enough.
Could you please try using the networkQuality command in the terminal to see if the test process is displayed in real time

2023-10-09.16.19.56.mov

@koinzhang
Copy link
Contributor Author

koinzhang commented Oct 9, 2023

Also, what does the page performance look like now during your speed tests with this extension? Can you take a screenshot if you can?

@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Oct 9, 2023

Sure @koinzhang

Raycast-sLPgt2ax

@koinzhang
Copy link
Contributor Author

koinzhang commented Oct 10, 2023

Hi @pernielsentikaer. It looks like different versions of sonoma (I'm using 14.0 on my device), networkQuality returns different strings, I've submitted a commit to fix this, please retest!

pernielsentikaer
pernielsentikaer approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit f1e8b77 into raycast:main Oct 10, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 10, 2023

Published to the Raycast Store:
https://raycast.com/koinzhang/network-speed

@raycastbot
Copy link
Collaborator

raycastbot commented Oct 10, 2023

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@koinzhang koinzhang deleted the bugfix/network-speed/fix-render-issue branch May 30, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pernielsentikaer pernielsentikaer pernielsentikaer approved these changes

Assignees

@pernielsentikaer pernielsentikaer

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: koinzhang/network-speed Issues related to the koinzhang/network-speed extension OP is author The OP of the PR is the author of the extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koinzhang @pernielsentikaer @raycastbot