Skip to content

feat(tailscale): add preferences for path and exec wrapper#8287

Merged
thomaslombart merged 4 commits intoraycast:mainfrom
erics118:update-tailscale
Sep 26, 2023
Merged

feat(tailscale): add preferences for path and exec wrapper#8287
thomaslombart merged 4 commits intoraycast:mainfrom
erics118:update-tailscale

Conversation

@erics118
Copy link
Contributor

@erics118 erics118 commented Sep 7, 2023

Description

Add a preferences for setting the path to the tailscale CLI
also adds a wrapper function for calling the tailscale CLI to be more DRY

Closes #8273

Screencast

Nothing

Checklist

@raycastbot raycastbot added the extension fix / improvement Label for PRs with extension's fix improvements label Sep 7, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Sep 7, 2023

Thank you for your contribution! 🎉

🔔 @samlinville @rosszurowski @samlinville @itsmingjie you might want to have a look.

@raycastbot raycastbot added the extension: tailscale Issues related to the tailscale extension label Sep 7, 2023
@thomaslombart thomaslombart self-assigned this Sep 11, 2023
@thomaslombart
Copy link
Contributor

thomaslombart commented Sep 11, 2023

It seems you have the same CI error than here. Could you fix it?

@erics118
Copy link
Contributor Author

CI errors fixed.

@thomaslombart
Copy link
Contributor

Code seems fine. I'm not using Tailscale so I'll let @samlinville, @rosszurowsk, oy @itsmingjie know if everything's good.

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Sep 26, 2023
@thomaslombart
Copy link
Contributor

I'm merging it since no one has responded to it.

@thomaslombart thomaslombart merged commit bed2b20 into raycast:main Sep 26, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/tailscale/tailscale

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@rosszurowski rosszurowski mentioned this pull request Sep 26, 2023
5 tasks
@erics118 erics118 deleted the update-tailscale branch September 27, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: tailscale Issues related to the tailscale extension status: stalled Stalled due inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tailscale] does not work with App Store installation out of the box

3 participants