Skip to content

feat(spotify-player): add more commands#8217

Merged
peduarte merged 25 commits intoraycast:mainfrom
erics118:update-spotify
Nov 20, 2023
Merged

feat(spotify-player): add more commands#8217
peduarte merged 25 commits intoraycast:mainfrom
erics118:update-spotify

Conversation

@erics118
Copy link
Contributor

@erics118 erics118 commented Sep 3, 2023 •
edited
Loading

Description

Multiple commands were added in this PR:

  • current track: shows the current track and artist/show, and the like state
  • seek: seek to an arbitrary position in the track
  • replay: go to the beginning of the song, replaying it
  • toggleRepeat -> cycleRepeat: there are three repeat states, now we can cycle between alll three
  • set volume: set the volume to an arbitrary percent, using an argument

Also, descriptions of the commands were shortened as the "Use this to" part gives no valuable information.

Fixes #8215

Screencast

This video goes over all of the commands added
CleanShot.2023-09-03.at.11.38.10.mp4

Checklist

@erics118
feat: modernize code
c816e47 
remove execa dependency, which was originally used to run `pbpaste`
now, use Clipboard.readText()
simplify readContent function
update package.json to have categories and new scripts
@erics118
chore: update deps and lint
ddd2af7
@erics118
feat: add set volume to anything command
598fa69
@erics118
feat: turn toggleRepeat into cycleRepeat
525fee2 
there are three repeat states, so this now cycles between all three rather
than just toggling between "off" and "context"
@erics118
feat: add seek and replay commands
f800dc8 
also add seek function to the api
@erics118
chore: format and standardize showHUD strings
72c8334
@erics118
feat: add current track command
de87782
@erics118
Revert "feat: modernize code"
1c8469e 
This reverts commit c816e47.

This was supposed to be for the update-change-case branch
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: spotify-player Issues related to the spotify-player extension labels Sep 3, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Sep 3, 2023 •
edited
Loading

Thank you for your contribution! 🎉

🔔 @mattisssa @peduarte @sxn @dillionverma @andreaselia @stuart @tonka3000 @dancannon @pernielsentikaer @stevensd2m @hjoelh @hobhouse you might want to have a look.

@erics118
Copy link
Contributor Author

erics118 commented Sep 3, 2023 •
edited
Loading

Closes #8215

@erics118
Copy link
Contributor Author

erics118 commented Sep 11, 2023

Which should the extension error with when there is no active device?

  • Nothing is currently playing (appears 10 before this PR)
  • No active device (appears 9 times before this PR)

@raycastbot raycastbot added the extension: mattisssa/spotify-player Issues related to the mattisssa/spotify-player extension label Sep 23, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 11, 2023

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Oct 11, 2023
@erics118
Copy link
Contributor Author

erics118 commented Oct 11, 2023

@peduarte Hi, could you take a look at this PR?

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Oct 11, 2023
@erics118
Copy link
Contributor Author

erics118 commented Oct 25, 2023

@peduarte @pernielsentikaer @sxn Sorry to bother, but could you guys take a look at this PR?

peduarte
peduarte reviewed Nov 18, 2023
View reviewed changes
@peduarte peduarte merged commit 6d865bf into raycast:main Nov 20, 2023
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 20, 2023

Published to the Raycast Store:
https://raycast.com/mattisssa/spotify-player

@raycastbot
Copy link
Collaborator

raycastbot commented Nov 20, 2023

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@erics118 erics118 deleted the update-spotify branch November 23, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peduarte peduarte peduarte approved these changes

@sxn sxn Awaiting requested review from sxn sxn is a code owner

@pernielsentikaer pernielsentikaer Awaiting requested review from pernielsentikaer pernielsentikaer is a code owner

Assignees

@peduarte peduarte

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: mattisssa/spotify-player Issues related to the mattisssa/spotify-player extension extension: spotify-player Issues related to the spotify-player extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Spotify Player] Toggle repeat- repeat one

3 participants

@erics118 @raycastbot @peduarte