Add pronounce-the-word extension#23351
Conversation
- Improve pronunciation extension with better API handling and UI - first commit
|
Congratulations on your new Raycast extension! 🚀 Due to our current reduced availability, the initial review may take up to 10-15 business days. Once the PR is approved and merged, the extension will be available on our Store. |
- Update Claude settings for git commands - Fix TypeScript errors
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
Greptile SummaryThis PR adds a new extension for learning word pronunciations with audio playback, phonetic transcriptions, and comprehensive definitions. The implementation is clean and well-structured, but has two critical issues that must be resolved:
The extension demonstrates good practices including:
Confidence Score: 2/5
Important Files Changed
|
| fs.writeFileSync(tempFilePath, buffer); | ||
|
|
||
| // Play using macOS afplay command | ||
| await execAsync(`afplay "${tempFilePath}"`); |
There was a problem hiding this comment.
logic: afplay is macOS-only but package.json declares Windows support. This will fail on Windows.
| await execAsync(`afplay "${tempFilePath}"`); | |
| // Play audio using platform-specific command | |
| const playCommand = process.platform === "win32" | |
| ? `powershell -c (New-Object Media.SoundPlayer "${tempFilePath}").PlaySync()` | |
| : `afplay "${tempFilePath}"`; | |
| await execAsync(playCommand); |
|
|
||
| ### Audio Playback | ||
|
|
||
| Audio files are downloaded and played using macOS's native `afplay` command for reliable playback in Raycast's Node.js environment. |
There was a problem hiding this comment.
style: Update documentation to reflect cross-platform audio support instead of macOS-only afplay
| "name": "pronounce", | ||
| "title": "Pronounce", | ||
| "description": "Learn to pronounce any word", | ||
| "mode": "view" |
There was a problem hiding this comment.
logic: Missing required metadata/ folder with Raycast-styled screenshots for view-type command. See https://developers.raycast.com/basics/prepare-an-extension-for-store#screenshots
Context Used: Rule from dashboard - What: Extensions with view-type commands must include a metadata/ folder containing Raycast-styled... (source)
|
Hi @SandeepBaskaran 👋 Thanks for your contribution 💪 Could you look into the suggestions from Greptile I'm looking forward to reviwing this extension again 🔥 I converted this PR into a draft until it's ready for the review, please press the button Feel free to contact me here or at Slack if you have any questions. |
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
|
This pull request has been automatically closed due to inactivity. Feel free to comment in the thread when you're ready to continue working on it 🙂 You can also catch us in Slack if you want to discuss this. |
|
@raycastbot reopen I've updated the PR to address the review comments:
|
|
I have updated the branch with the requested changes:
I also fixed the commit author email. Could you please reopen this PR for review? |
|
We can't reopen it since you removed the forked repos branch. You need to open a new PR to get back into the queue. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder