Add domain field to fastmail-masked-email extension#18468
Add domain field to fastmail-masked-email extension#18468lucacome wants to merge 1 commit intoraycast:mainfrom
Conversation
|
Thank you for your first contribution! 🎉 🔔 @PhotonQuantum @klaaspieter @mike182uk you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
There was a problem hiding this comment.
PR Summary
The PR adds a domain field to the Fastmail Masked Email extension with corresponding updates to both the UI and API integration, along with a minor update to the contributor list.
- extensions/fastmail-masked-email/src/create.tsx: Integrated domain field into form input, FormValues type, and both submission handlers.
- extensions/fastmail-masked-email/src/fastmail.ts: Passed the unvalidated domain to the API request payload; consider adding normalization/validation.
- extensions/fastmail-masked-email/CHANGELOG.md: New changelog entry is correctly placed at the top and uses the
{PR_MERGE_DATE}template. - extensions/fastmail-masked-email/package.json: Contributor list updated with 'lucacome' as expected.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Hi @lucacome👋 Thanks for your contribution 🔥 Code looks okay, @PhotonQuantum can you check this? I don't use this service 😊 |
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
|
@lucacome I missed this one. I can take a look if you want? |
|
That would be nice @klaaspieter 🔥 |
klaaspieter
left a comment
There was a problem hiding this comment.
Can you also add the domain to the keywords here?
Other than that looks good to me. Although I'm curious what you think about how this displays either the description or the domain https://github.com/lucacome/extensions/blob/cd641713c4bab2ebcae5a2dbd7613699291636f6/extensions/fastmail-masked-email/src/list.tsx#L133. Do you think we should somehow show them both?
Thinking about my own usage I've been using the description for the domain so nothing changes for me except that I'll start using the domain field now.
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
Description
Added domain field to the create command to allow users to specify a domain when creating a new masked email.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool