Conversation
- Fix env issues - Initial commit
|
Thank you for your first contribution! 🎉 🔔 @EvanZhouDev you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
PR Summary
This PR adds environment variable handling improvements to the MCP extension, specifically addressing client initialization failures by properly sourcing shell environment variables.
- Added new
initEnv()function in/extensions/mcp/src/getProcessedClients.tsto properly load shell environment variables - Added changelog entry "Fix issue caused by passing
envinmcp-config.json" in/extensions/mcp/CHANGELOG.md - Consider using
showFailureToastfrom@raycast/utilsin the catch blocks ofinitEnv()andgetUserShellPath() - Recommend wrapping
raycastAiClientInstance.connect()calls in try-catch blocks for better error handling
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
@radzio LGTM, probably just fix the lint error 😄 |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@EvanZhouDev Consider it done :) |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@radzio). |
Description
This PR fixes #17839
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder