Skip to content

Update keepassxc extension#17758

Merged
raycastbot merged 8 commits intoraycast:mainfrom
pabroux:ext/keepassxc
Mar 12, 2025
Merged

Update keepassxc extension#17758
raycastbot merged 8 commits intoraycast:mainfrom
pabroux:ext/keepassxc

Conversation

@pabroux
Copy link
Contributor

@pabroux pabroux commented Mar 11, 2025 •
edited
Loading

Description

Hello 👋🏻,

⚠️ Still the author here and not the contributor (raycastbot still incorrectly notifies the former author zkytech).

Here is what I've done:

Changed

  • Use a global info message about security when the database is locked.
  • Update screenshot about the database being locked.
  • Use more explicite error messages when unable to exececute the keepassxc-cli command.

Fixed

  • Use a correct link for the KeePassXC image in the README.

Removed

  • The test guide.

Checklist

@pabroux
Update keepassxc extension
0ee5a24 
- chore(CHANGELOG): add logs for 1.5.5.
- fix: handle the invalid credentials error message.
- chore(npm): update packages.
- chore: remove test guide.
- docs(assets): update screenshot for unlocking database.
- feat(unlock): improve UI for info.
- chore: add .vscode to .gitignore.
- docs(README): fix link for image.
- chore: delete \'.vscode\'.
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: keepassxc Issues related to the keepassxc extension labels Mar 11, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Mar 11, 2025 •
edited
Loading

Thank you for your contribution! 🎉

🔔 @zkytech you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

greptile-apps[bot]
greptile-apps bot reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the KeePassXC extension with improved error messaging, documentation changes, and dependency updates.

  • There's a spelling error in CHANGELOG.md: "explicite" should be "explicit" in the error message description
  • The error message in keepass-loader.ts removes specific error codes which could make debugging harder, consider keeping detailed errors in logs
  • The security message in unlock-database.tsx is now consolidated but could be more prominent given its importance
  • Dependencies @raycast/api and @raycast/utils have been updated to newer minor versions
  • The README image source now correctly uses repository-relative paths instead of external URLs

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

pabroux and others added 2 commits March 11, 2025 16:04
@pabroux @greptile-apps
chore(CHANGELOG): fix typos.
69db75e 
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@pabroux @greptile-apps
feat: add again exit code.
6c349e7 
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@LitoMore
Copy link
Contributor

LitoMore commented Mar 11, 2025

Still the author here and not the contributor (raycastbot still incorrectly notifies the former author zkytech)

It's because the mapping data in the raycast2github.json is wrong. We might need to fix it manually:

extensions/.github/raycast2github.json

Line 1830 in 201037d

"pabroux": "zkytech",

@pabroux
Copy link
Contributor Author

pabroux commented Mar 11, 2025 •
edited
Loading

Still the author here and not the contributor (raycastbot still incorrectly notifies the former author zkytech)

It's because the mapping data in the raycast2github.json is wrong. We might need to fix it manually:

extensions/.github/raycast2github.json

Line 1830 in 201037d

"pabroux": "zkytech",

I've done a commit to change the mapping 4b6df1b.

Edit: 381a6db to merge conflicts.

@pabroux pabroux requested a review from LitoMore March 11, 2025 18:24
LitoMore
LitoMore reviewed Mar 11, 2025
View reviewed changes
@pabroux pabroux requested a review from LitoMore March 12, 2025 00:32
LitoMore
LitoMore approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pernielsentikaer This PR has an update for the raycast2github.json to fix an incorrect mapping. This might need a review from you.

@pernielsentikaer pernielsentikaer self-assigned this Mar 12, 2025
@pernielsentikaer
Copy link
Collaborator

pernielsentikaer commented Mar 12, 2025

Should be fine in this case; sometimes it gets confused 🤞

@raycastbot raycastbot merged commit 21845ef into raycast:main Mar 12, 2025
2 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

Published to the Raycast Store:
https://raycast.com/pabroux/keepassxc

@raycastbot
Copy link
Collaborator

raycastbot commented Mar 12, 2025

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@pabroux pabroux deleted the ext/keepassxc branch March 12, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pernielsentikaer pernielsentikaer pernielsentikaer approved these changes

+2 more reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@LitoMore LitoMore LitoMore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pernielsentikaer pernielsentikaer

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: keepassxc Issues related to the keepassxc extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pabroux @raycastbot @LitoMore @pernielsentikaer