PPL: Improved cached logic and removed unused fields#17666
PPL: Improved cached logic and removed unused fields#17666pernielsentikaer merged 4 commits intomainfrom
Conversation
|
Thank you for your contribution! 🎉 🔔 @danielsequeira you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
PR Summary
This PR improves the Portuguese Primeira Liga extension by enhancing newspaper caching logic and removing unused fields from various components.
- Updated cache key in
extensions/portuguese-primeira-liga/src/hooks/useNewspapers.tsto include year for better uniqueness:newspapers-${dayMonthYear} - Removed unused 'form' field from Table interface in
extensions/portuguese-primeira-liga/src/types/index.ts - Removed unused 'position' field from Player interface in
extensions/portuguese-primeira-liga/src/types/index.ts - Lists in
standings.tsxandtopScorers.tsxcorrectly useisLoadingprop to avoid empty state flicker
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
pernielsentikaer
left a comment
There was a problem hiding this comment.
Fixed 7 vulnerabilities (4 moderate, 3 high)
Added missing icon
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Improved newspapers cached logic and removed fields without data.
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool