Update connect-to-vpn extension#17649
Conversation
- fix: improve menubar icon update speed and fix linting issues - Initial commit
|
Thank you for your first contribution! 🎉 🔔 @rasmusbe @sato11 @stonerl @vpukhanov @Yshmeel you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
|
This PR significantly improves the menubar icon update speed when connecting/disconnecting via the main Raycast interface. Previously, the icon would update with a delay of 15-20 seconds, now it updates almost instantly. |
There was a problem hiding this comment.
PR Summary
This PR significantly improves the Connect to VPN extension with faster menubar updates and better synchronization between the main extension and menubar interface.
- The changelog entry for "Performance Improvements" needs to end with
{PR_MERGE_DATE}template string - New
store.tsimplementation effectively manages VPN status updates and menubar refresh state - Reduced polling interval from 500ms to 300ms and added 50ms menubar refresh checks for more responsive UI
- Consider using
showFailureToastfrom@raycast/utilsinstead of manualshowToastwithToast.Style.Failure - Added extensive logging for debugging which should be cleaned up/removed before merging
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
I'm having issues with the Prettier formatting check in CI. Locally, ray lint --fix reports no issues, but CI still fails. Could someone from the Raycast team help me understand what's wrong with the formatting? |
|
@rasmusbe can you check this? |
|
Yes, I'll test it later today or tomorrow 👍 |
|
Awesome, thanks 🔥 |
|
Thank you, I am currently working on the next update and I really want to make it possible to assign hotkeys to specific connections. So that you can connect or disconnect using a pre-set key combination. Initially, I wanted to try to make it so that the plugin settings would display available connections and you could assign hotkeys there. But I still haven't found a way to do this... Now I have a slightly crooked method, I made a command that allows you to generate shell scripts for each connection and then through "Script Commands" you can assign an alliance or hotkey for the desired connection. But this is some kind of crooked method and I don't like it... Although it is a working method. |
|
@rasmusbe @pernielsentikaer hi, I know you have a lot to do, but just in case I wanted to remind you about this pull request... |
rasmusbe
left a comment
There was a problem hiding this comment.
Sorry, I've tested it but forgot to hit send on my approval. Everything worked perfect!
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder