[YouTube Downloader] Avoid to run onSubmit while fetching video#17641
[YouTube Downloader] Avoid to run onSubmit while fetching video#17641raycastbot merged 2 commits intoraycast:mainfrom
onSubmit while fetching video#17641Conversation
|
Thank you for your contribution! 🎉 🔔 @vimtor @pernielsentikaer @darmiel @ridemountainpig @remorses @anwarulislam you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
There was a problem hiding this comment.
PR Summary
This PR adds validation checks to prevent form submission while fetching video data and ensures a format is selected before downloading in the YouTube Downloader extension.
- Added format validation check in
extensions/youtube-downloader/src/index.tsxto prevent downloads without a selected format - Added new changelog entry at the top of
CHANGELOG.mdwith proper{PR_MERGE_DATE}template - The
onSubmithandler now properly handles the loading state to prevent duplicate submissions - Consider using
showFailureToastfrom@raycast/utilsinstead of manualshowToastwith failure style in error handling
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
onSubmit while fetching videoonSubmit while fetching video
Description
Closes #17625
onSubmitwhile fetching videoChecklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool