Conversation
|
Congratulations on your new Raycast extension! 🚀 Due to our current reduced availability, the initial review may take up to 10-15 business days Once the PR is approved and merged, the extension will be available on our Store. |
There was a problem hiding this comment.
PR Summary
Added a new CCF Conference extension that allows users to search and view detailed information about Computer Science academic conferences and their submission deadlines from the CCF-DDL repository.
- The extension in
/extensions/ccfddl/src/search.tsxfetches conference data from GitHub and implements caching, but lacks cache expiration logic and error handling for the fetch operations - The List component in
/extensions/ccfddl/src/search.tsxshould use theisLoadingstate to avoid empty state flicker as per Raycast guidelines - The extension should include a
metadatafolder with screenshots since it has aviewcommand inpackage.json - Consider adding a
subtitleto the search command inpackage.jsonwith the service name for better context - The
fetchFromGitHubfunction should be wrapped in a try-catch block for better error handling
10 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
|
@greptileai can you check again |
There was a problem hiding this comment.
PR Summary
(updates since last review)
This update improves error handling and UI components in the CCF Conference extension, particularly in the search functionality and data fetching logic.
- The
showToasterror handling in/extensions/ccfddl/src/search.tsxcould be simplified usingshowFailureToastfrom@raycast/utilsfor better consistency - The
Listcomponent in/extensions/ccfddl/src/list.tsxshould be refactored to avoid duplicate code withsearch.tsx - The
CACHE_TTLconstant in/extensions/ccfddl/src/api.tsis defined but never used when setting cache data - The
getMarkdownTablefunction in/extensions/ccfddl/src/utils.tscould benefit from template literal syntax for better readability
Note: These points focus on the most recent changes and do not repeat issues from the previous review.
6 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
Let me know if you need help with anything |
Hello @pernielsentikaer , thanks a lot! |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
A CCF DDL extension has been added to search CCF conferences from Raycast.
CCF DDL is a collaborative organization that maintains a list Computer Science academic conferences and it's deadlines (submitting dates). The repos https://github.com/ccfddl/ccf-deadlines have about 7k stars.
Related work:
I found a relevant extension that checks the ranking of conferences and journals. However, this extension's primary focus is on dynamically updating submission deadlines and accepting rates. I believe this extension should be maintained by CCFDDL community in the future. I will list it in Readme if this PR has been merged.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool