Conversation
- Merge branch \'contributions/merge-1740997335495\' - Pull contributions - Merge branch \'contributions/merge-1740997287259\' - Pull contributions - Merge branch \'contributions/merge-1740997272930\' - Pull contributions - Merge branch \'contributions/merge-1740997253354\' - Pull contributions - added month to the attendances loaded message
|
Thank you for the update! 🎉 Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
PR Summary
This PR updates the Personio extension by enhancing the toast message to include the selected month when attendances are loaded.
- Modified
extensions/personio/src/api/attendances.tsxto display a more informative success message that includes both month and year (${selectedMonth}/2024) instead of just the year - The change provides users with better context about which month's attendance data was successfully loaded
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| await showToast({ | ||
| title: "Loaded Attendances", | ||
| message: `${attendances.length} Attendances in 2024 loaded successfully!`, | ||
| message: `${attendances.length} Attendances in ${selectedMonth}/2024 loaded successfully!`, |
There was a problem hiding this comment.
style: The year 2024 is hardcoded in the message. Consider using ${currentYear} instead of hardcoding 2024 to make the message future-proof.
| message: `${attendances.length} Attendances in ${selectedMonth}/2024 loaded successfully!`, | |
| message: `${attendances.length} Attendances in ${selectedMonth}/${currentYear} loaded successfully!`, |
There was a problem hiding this comment.
Added the recommended changes
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder