Update bitwarden extension: fix search when vault contains SSH keys by jose-elias-alvarez · Pull Request #17492 · raycast/extensions

jose-elias-alvarez · 2025-03-02T17:20:36Z

Description

Currently, the Search Vault command, the extension's main entry point, errors out if the vault contains an SSH key, a new item type added in late 2024. (This is why some users may not have any problems and also why downgrading to an earlier version of the CLI "fixes" the issue, since older versions just ignore SSH keys.)

This PR updates the extension's code to correctly handle the new item type. It displays SSH keys in the list of search results and adds an action to copy the public key to the clipboard. (I can also add an action to copy the private key and / or key fingerprint, though I'm not sure how useful these would be.)

I also added a check to ensure that the command won't completely error out if a new item type is added in the future (it'll have placeholder icons and no actions, which seems sensible until proper handling can be added in a PR similar to this one).

Also, while not related, I went ahead and fixed a warning generated by specifying a shortcut for Action.SubmitForm (Raycast is already overriding this to Command + Enter).

Screencast

An SSH key in search results:

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- docs: update changelog - chore: unset removed shortcut - fix: handle ssh keys in search - Initial commit

raycastbot · 2025-03-02T17:20:52Z

Thank you for your contribution! 🎉

🔔 @jomifepe @daniel-stoneuk @andreaselia @eth-p @YamenSharaf @undefinedzack @anirudhganwal06 @ivaarsson @gasparhabif @marinsokol you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

pernielsentikaer · 2025-03-02T21:34:30Z

@jomifepe can you check this?

greptile-apps

PR Summary

This PR adds support for SSH keys in the Bitwarden extension, fixing a critical bug where the Search Vault command would error out when encountering SSH keys in a user's vault.

Added proper handling for SSH_KEY item type in src/types/vault.ts with a new interface for SSH key properties
Created new CopyPublicKeyAction.tsx component to allow copying public keys to clipboard
Updated caching utility in caching.ts to properly handle SSH key items while maintaining security
Added icon and label mappings for SSH keys in general.ts and labels.ts for consistent UI representation
Implemented defensive error handling in useItemAccessories.ts to prevent crashes from unknown item types in the future

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{13 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-03-02T21:40:14Z

extensions/bitwarden/src/types/vault.ts

+export interface SshKey {
+  privateKey: string;
+  publicKey: string;
+  keyFingerprint: string;
+}


style: The SshKey interface properties are all defined as required strings without null options, unlike other interfaces like Card and Identity which allow null values. Consider whether these fields should also allow null values for consistency and to handle potential edge cases where some fields might not be present.

Good bot. This is a fair observation, but at least as of now, SSH keys are not directly editable in the Bitwarden GUI (you have to either import them or generate them in Bitwarden itself), so I don't believe these are truly nullable, but I'm happy to change this for consistency.

Looks good, we can leave it like this and change if necessary.

jomifepe

Great addition 💯
Looks clean overall. I've left a few comments.

extensions/bitwarden/src/components/RepromptForm.tsx

extensions/bitwarden/src/components/searchVault/actions/CopyPublicKeyAction.tsx

extensions/bitwarden/src/components/searchVault/ItemActionPanel.tsx

- feat: add ssh key actions - fix: use transient copy preference

jose-elias-alvarez · 2025-03-03T16:22:33Z

Thanks for the feedback @jomifepe, should be good to go now.

jomifepe

Looks great, awesome job finding the culprit of that common error!

Ship it

extensions/bitwarden/src/components/searchVault/ItemActionPanel.tsx

jomifepe · 2025-03-03T22:14:08Z

extensions/bitwarden/src/types/vault.ts

+export interface SshKey {
+  privateKey: string;
+  publicKey: string;
+  keyFingerprint: string;
+}


Looks good, we can leave it like this and change if necessary.

…l.tsx Co-authored-by: José Pereira <7235666+jomifepe@users.noreply.github.com>

pernielsentikaer · 2025-03-03T22:32:46Z

Can we merge as it is now @jomifepe

jomifepe · 2025-03-03T22:39:06Z

Can we merge as it is now @jomifepe

I'm not sure if the comment was resolved, it's still not exported/imported correctly 👀

But it wasn't a blocker, so feel free to merge anyway!

pernielsentikaer · 2025-03-04T05:48:13Z

Let's do that and have an eye out 🙂

pernielsentikaer

Approved 🔥

github-actions · 2025-03-04T05:50:49Z

Published to the Raycast Store:
https://raycast.com/jomifepe/bitwarden

raycastbot · 2025-03-04T05:50:51Z

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Update bitwarden extension

cff807b

- docs: update changelog - chore: unset removed shortcut - fix: handle ssh keys in search - Initial commit

jose-elias-alvarez requested a review from pernielsentikaer as a code owner March 2, 2025 17:20

raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: bitwarden Issues related to the bitwarden extension labels Mar 2, 2025

fix: add action + handle cache

62e1c0d

jose-elias-alvarez changed the title ~~Update bitwarden extension~~ Update bitwarden extension: fix search when vault contains SSH keys Mar 2, 2025

pernielsentikaer self-assigned this Mar 2, 2025

greptile-apps bot reviewed Mar 2, 2025

View reviewed changes

jomifepe reviewed Mar 2, 2025

View reviewed changes

extensions/bitwarden/src/components/RepromptForm.tsx Show resolved Hide resolved

extensions/bitwarden/src/components/searchVault/actions/CopyPublicKeyAction.tsx Outdated Show resolved Hide resolved

extensions/bitwarden/src/components/searchVault/ItemActionPanel.tsx Show resolved Hide resolved

Update bitwarden extension

d0dc2cb

- feat: add ssh key actions - fix: use transient copy preference

jomifepe approved these changes Mar 3, 2025

View reviewed changes

Update extensions/bitwarden/src/components/searchVault/ItemActionPane…

11ace29

…l.tsx Co-authored-by: José Pereira <7235666+jomifepe@users.noreply.github.com>

raycastbot added the OP is contributor The OP of the PR is a contributor of the extension label Mar 3, 2025

pernielsentikaer added 2 commits March 3, 2025 23:27

Update ItemActionPanel.tsx

00c091d

Update ItemActionPanel.tsx

cfa2496

pernielsentikaer approved these changes Mar 4, 2025

View reviewed changes

Update CHANGELOG.md and optimise images

cabd220

raycastbot merged commit d0348e7 into raycast:main Mar 4, 2025
2 checks passed

jose-elias-alvarez deleted the ext/bitwarden branch March 4, 2025 14:53

Conversation

jose-elias-alvarez commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screencast

Checklist

Uh oh!

raycastbot commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pernielsentikaer commented Mar 2, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

jose-elias-alvarez Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

jomifepe Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

jomifepe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jose-elias-alvarez commented Mar 3, 2025

Uh oh!

jomifepe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jomifepe Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

pernielsentikaer commented Mar 3, 2025

Uh oh!

jomifepe commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pernielsentikaer commented Mar 4, 2025

Uh oh!

pernielsentikaer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

raycastbot commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jose-elias-alvarez commented Mar 2, 2025 •

edited

Loading

raycastbot commented Mar 2, 2025 •

edited

Loading

jomifepe left a comment •

edited

Loading

jomifepe commented Mar 3, 2025 •

edited

Loading

pernielsentikaer left a comment •

edited

Loading