[extensions/get-favicon] new feature: specify icon size#17472
[extensions/get-favicon] new feature: specify icon size#17472raycastbot merged 12 commits intoraycast:mainfrom
Conversation
|
Thank you for your contribution! 🎉 🔔 @vimtor @robotdestroy @LeonChenWenJia you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
PR Summary
Added support for specifying favicon icon size in settings, with minor refactoring to extract common interfaces and preferences to a separate file.
- Added new
default_icon_sizepreference inpackage.jsonwith dropdown options from 16x16 to 256x256 - Created new
common.tsxfile to centralize interfaces for Arguments and Preferences - Implemented size parameter in
getFaviconcalls incopy.tsandcopy-url.ts, but missing indownload.ts - Left debugging
console.logstatements in all three command files that should be removed - Updated README.md with configuration options, but contains a typo "commond" in the roadmap section
7 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
| export interface Arguments { | ||
| url: string; | ||
| } | ||
|
|
||
| export interface Preferences { | ||
| default_icon_size: number; | ||
| downloadDirectory: string; | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi, Preference can be removed.
I don't understand the second one. How should I use the argument? Thanks.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
pernielsentikaer
left a comment
There was a problem hiding this comment.
You're right, it uses an very old version of @raycast/api
Can you try to update with npx @raycast/migration@latest . and fix if any errors occurs?
That should give you raycast-env.d.ts which has the type for Preference and Arguments
|
Do you need help fixing the errors? |
Finally I found the generated "raycast-env.d.ts" is not included in the tsconfig.json. 
|
Hi, @pernielsentikaer , I need some help regarding the dependencies. For example, run |
|
Now we're back with errors, do you want to handle them @ViGeng |
Hi, I think it is working now. I skipped the 'any' type checking by applying a rule. |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description