Add goodlinks extension by nicolas-marien · Pull Request #17335 · raycast/extensions

nicolas-marien · 2025-02-26T08:12:53Z

Description

List unread
Save clipboard
Open random link

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- chore: add readme - chore: add changelog - chore: add screenshot - fix: lint - chore: rename command - feat: add random link command - chore: remove unused types - feat: list links - chore: ensure application is installed - feat: initial commit

raycastbot · 2025-02-26T08:13:16Z

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

pernielsentikaer · 2025-03-03T12:29:10Z

@greptileai can you do the initial review while I test the extension 😊

greptile-apps

PR Summary

This PR adds a new GoodLinks extension for Raycast with commands to save links from clipboard, list unread links, and open random links from the GoodLinks app.

The description for random-link command in package.json is incomplete, missing what it opens a random link "from"
The starred property in src/utils/types.ts is typed as string but appears to be used as a boolean in the codebase
The openLink function in src/utils/url-scheme.ts doesn't encode the URL parameter, which could cause issues with special characters
The open function in src/list-unread.tsx should be wrapped in a try/catch block to handle potential errors
Missing empty state handling in src/list-unread.tsx when no unread links are found, which could lead to UI flicker

_{💡 (4/5) You can add custom instructions or style guidelines for the bot here!}

_{16 file(s) reviewed, 10 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/goodlinks/package.json

extensions/goodlinks/README.md

extensions/goodlinks/src/api/save-link.ts

extensions/goodlinks/src/save-link.ts

extensions/goodlinks/src/list-unread.tsx

extensions/goodlinks/src/utils/types.ts

extensions/goodlinks/src/utils/url-scheme.ts

pernielsentikaer

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

extensions/goodlinks/package.json

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Co-authored-by: Per Nielsen Tikær <per@raycast.com>

nicolas-marien · 2025-03-03T12:58:31Z

Thanks @pernielsentikaer 🤘
I'll make some adjustments and get back to you.

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

nicolas-marien · 2025-03-03T15:44:26Z

@pernielsentikaer I made some changes.
Let me know if that's fine by you 😄

pernielsentikaer · 2025-03-04T06:34:24Z

@greptileai can you check again

greptile-apps

PR Summary

(updates since last review)

This PR continues development of the GoodLinks extension, with several issues still needing attention for better reliability and user experience.

The README.md has a duplicate line for "Open random link" with inconsistent naming (GoodLink vs GoodLinks)
The showMustBeInstalledToast in isApplicationInstalled.ts should use showFailureToast from @raycast/utils for consistency
The command function in random-link.ts should have a more descriptive name and include try/catch for the open call
Since there are view commands in package.json, a metadata folder with screenshots should be added per store guidelines
The List component in list-unread.tsx should use isLoading to avoid empty state flicker

_{16 file(s) reviewed, 11 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/goodlinks/src/api/list-links.ts

extensions/goodlinks/package.json

extensions/goodlinks/src/api/save-link.ts

extensions/goodlinks/src/random-link.ts

extensions/goodlinks/src/utils/applescript.ts

extensions/goodlinks/src/utils/isApplicationInstalled.ts

pernielsentikaer · 2025-03-04T08:08:07Z

Can you check a last time @nicolas-marien

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

pernielsentikaer

Hi 👋

Looks good to me, approved 🔥

nicolas-marien · 2025-03-04T13:19:54Z

Thank you @pernielsentikaer

github-actions · 2025-03-04T13:23:19Z

Published to the Raycast Store:
https://raycast.com/nicolas-marien/goodlinks

raycastbot · 2025-03-04T13:23:21Z

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Add goodlinks extension

e1e9d7e

- chore: add readme - chore: add changelog - chore: add screenshot - fix: lint - chore: rename command - feat: add random link command - chore: remove unused types - feat: list links - chore: ensure application is installed - feat: initial commit

raycastbot added the new extension Label for PRs with new extensions label Feb 26, 2025

nicolas-marien marked this pull request as draft February 26, 2025 08:15

chore: update icon

17d7355

nicolas-marien marked this pull request as ready for review February 26, 2025 08:19

pernielsentikaer self-assigned this Mar 3, 2025

greptile-apps bot reviewed Mar 3, 2025

View reviewed changes

pernielsentikaer requested changes Mar 3, 2025

View reviewed changes

extensions/goodlinks/package.json Show resolved Hide resolved

extensions/goodlinks/package.json Show resolved Hide resolved

extensions/goodlinks/package.json Show resolved Hide resolved

nicolas-marien and others added 4 commits March 3, 2025 13:55

chore: apply suggestion.

e0208e7

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chore: apply suggestion

3fa0cc9

Co-authored-by: Per Nielsen Tikær <per@raycast.com>

chore: apply suggestion

7a8d34c

Co-authored-by: Per Nielsen Tikær <per@raycast.com>

chore: apply suggestion

fc10d3b

Co-authored-by: Per Nielsen Tikær <per@raycast.com>

nicolas-marien and others added 5 commits March 3, 2025 16:12

chore: apply suggestion

015a7bd

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Merge branch 'raycast:main' into ext/goodlinks

d2f538b

chore: better state management

161aba4

fix: incorrect type

b1fb915

fix: better error handling

424ecd1

nicolas-marien requested a review from pernielsentikaer March 3, 2025 15:44

greptile-apps bot reviewed Mar 4, 2025

View reviewed changes

Update README.md

e44a7bb

nicolas-marien and others added 4 commits March 4, 2025 09:23

chore: apply suggestion

1771cc2

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chore: apply suggestion

2584314

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chore: improve app installation detection logic

cc03a77

chore: error handling and function renaming

0448fb8

chore: remove mardown callout

fa815d6

pernielsentikaer approved these changes Mar 4, 2025

View reviewed changes

Update CHANGELOG.md and optimise images

b0c3da1

raycastbot merged commit 1350fb0 into raycast:main Mar 4, 2025
2 checks passed

Conversation

nicolas-marien commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screencast

Checklist

Uh oh!

raycastbot commented Feb 26, 2025

Uh oh!

pernielsentikaer commented Mar 3, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-marien commented Mar 3, 2025

Uh oh!

nicolas-marien commented Mar 3, 2025

Uh oh!

pernielsentikaer commented Mar 4, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pernielsentikaer commented Mar 4, 2025

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-marien commented Mar 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

raycastbot commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicolas-marien commented Feb 26, 2025 •

edited

Loading