Update yabai extension by lhy-a · Pull Request #17311 · raycast/extensions

lhy-a · 2025-02-25T11:40:49Z

Description

Adds "Focus Next Same App" command
- Focuses on the next window with the same application name
- MacOS has same feature, but it is only available in the current space
Adds "Search Windows" command
- Searches for windows managed by Yabai
- Allows to search by window title or application name , it is really useful when windows have the same app name

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- - Adds "Focus Next Same App" command - Focuses on the next window with the same application name - MacOS has same feature, but it is only available in the current space - Adds "Search Windows" command - Searches for windows managed by Yabai - Allows to search by window title or application name , it is really useful when windows have the same app name - Initial commit

raycastbot · 2025-02-25T11:41:12Z

Thank you for your contribution! 🎉

🔔 @krzysztoff1 @rubentsirunyan @webdesus @d34dh0r53 you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

pernielsentikaer · 2025-02-25T13:36:48Z

Asked a PR review bot to make the review, let's see if it finds anything

greptile-apps

PR Summary

This PR adds two new commands to the Yabai extension: "Focus Next Same App" for cycling through windows of the same application and "Search Windows" for finding windows by title or app name with Pinyin support.

Added focus-next-same-app.tsx to cycle through windows of the same application, even across spaces
Added search-windows.tsx with Chinese Pinyin search support using the new tiny-pinyin dependency
Created window-utils.ts helper with a common BaseWindow interface and sortWindows function for consistent window handling
The launchCommand in search-windows.tsx should be wrapped in a try-catch block for better error handling
Performance logging in search-windows.tsx provides useful debugging information but could be optimized for production

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{6 file(s) reviewed, 2 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/yabai/CHANGELOG.md

extensions/yabai/src/helpers/window-utils.ts

pernielsentikaer

Added a few more 🙂

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

extensions/yabai/package.json

Co-authored-by: Per Nielsen Tikær <per@raycast.com>

d34dh0r53

This is awesome! Just a nit and a suggestion from me.

extensions/yabai/src/helpers/window-utils.ts

2. fix code style

pernielsentikaer · 2025-02-26T06:58:44Z

@greptileai could you do another review

greptile-apps

PR Summary

(updates since last review)

This PR enhances the Yabai extension with two new window management commands that work across spaces, providing functionality beyond macOS's native capabilities.

The search-windows.tsx implementation should use showFailureToast from @raycast/utils instead of manual error handling with showToast
The List component in search-windows.tsx properly uses isLoading state to prevent empty state flicker
The findAppPath function is duplicated in both search-windows.tsx and windows-list-current-space.tsx - consider extracting to a shared utility
The performance logging in search-windows.tsx is thorough but could be conditionally enabled for development only
The CHANGELOG entry correctly uses the {PR_MERGE_DATE} placeholder that will be automatically replaced

_{6 file(s) reviewed, 2 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/yabai/src/helpers/window-utils.ts

extensions/yabai/src/search-windows.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

pernielsentikaer · 2025-02-26T07:56:16Z

@krzysztoff1 do you want to check this?

pernielsentikaer

Hi 👋

Looks good to me, approved 🔥

github-actions · 2025-02-26T08:36:23Z

Published to the Raycast Store:
https://raycast.com/krzysztoff1/yabai

raycastbot · 2025-02-26T08:36:25Z

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

krzysztoff1 · 2025-02-26T08:36:28Z

Thanks for your contribution! @lhy-a

raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: yabai Issues related to the yabai extension labels Feb 25, 2025

huanying liu added 2 commits February 25, 2025 19:50

fix package-lock.json

4b93e81

fix package

3037f63

pernielsentikaer self-assigned this Feb 25, 2025

greptile-apps bot reviewed Feb 25, 2025

View reviewed changes

extensions/yabai/CHANGELOG.md Outdated Show resolved Hide resolved

extensions/yabai/src/helpers/window-utils.ts Outdated Show resolved Hide resolved

pernielsentikaer requested changes Feb 25, 2025

View reviewed changes

extensions/yabai/package.json Show resolved Hide resolved

extensions/yabai/package.json Show resolved Hide resolved

Update extensions/yabai/package.json

fcdf22e

Co-authored-by: Per Nielsen Tikær <per@raycast.com>

d34dh0r53 suggested changes Feb 25, 2025

View reviewed changes

extensions/yabai/src/helpers/window-utils.ts Outdated Show resolved Hide resolved

extensions/yabai/src/helpers/window-utils.ts Outdated Show resolved Hide resolved

huanying liu and others added 2 commits February 26, 2025 11:37

1. use a better windows order rule

7a18b28

2. fix code style

Merge branch 'raycast:main' into ext/yabai

a77e194

lhy-a closed this Feb 26, 2025

lhy-a deleted the ext/yabai branch February 26, 2025 03:57

lhy-a restored the ext/yabai branch February 26, 2025 03:58

lhy-a deleted the ext/yabai branch February 26, 2025 03:58

lhy-a restored the ext/yabai branch February 26, 2025 06:37

Merge branch 'raycast:main' into ext/yabai

0ea2db0

lhy-a reopened this Feb 26, 2025

greptile-apps bot reviewed Feb 26, 2025

View reviewed changes

extensions/yabai/src/helpers/window-utils.ts Outdated Show resolved Hide resolved

extensions/yabai/src/search-windows.tsx Show resolved Hide resolved

lhy-a requested review from d34dh0r53 and pernielsentikaer February 26, 2025 07:27

lhy-a and others added 3 commits February 26, 2025 15:36

Update extensions/yabai/src/helpers/window-utils.ts

f5a1934

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update extensions/yabai/src/search-windows.tsx

ef385c8

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update search-windows.tsx

2c5ee56

krzysztoff1 approved these changes Feb 26, 2025

View reviewed changes

pernielsentikaer approved these changes Feb 26, 2025

View reviewed changes

raycastbot merged commit 96b0b92 into raycast:main Feb 26, 2025
9 checks passed

Conversation

lhy-a commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screencast

Checklist

Uh oh!

raycastbot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pernielsentikaer commented Feb 25, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

d34dh0r53 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pernielsentikaer commented Feb 26, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

pernielsentikaer commented Feb 26, 2025

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2025

Uh oh!

raycastbot commented Feb 26, 2025

Uh oh!

krzysztoff1 commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lhy-a commented Feb 25, 2025 •

edited

Loading

raycastbot commented Feb 25, 2025 •

edited

Loading