Add esports-pass extension by rafaelvicio · Pull Request #17269 · raycast/extensions

rafaelvicio · 2025-02-23T21:03:57Z

Description

Esports Pass
A extesnons for esports. League of Legends, VALORANT, CS and more.

Show Matches - Show esports matches
Show Results - Show esports results
Show Tournaments - Show esports tournaments

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- feat: public extension - feat: change screnshots - feat: add metadata - feat: add changelog - feat: use npm - feat: fix tournament name - feat: add tournaments command - feat: refact commands - init

raycastbot · 2025-02-23T21:04:17Z

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

pernielsentikaer · 2025-03-01T06:09:58Z

Thanks for your contribution, it could maybe make sense to unify unto one extension, I can see that we have 2/3 games in the store already made by @vimtor

What do you think?

greptile-apps

PR Summary

Added a new Esports Pass extension that allows users to view esports matches, results, and tournaments for games like League of Legends, VALORANT, and Counter-Strike.

The CHANGELOG.md entry should use {PR_MERGE_DATE} instead of an actual date (2025-02-23)
README.md contains typos: "A extesnons for esports?" should match the title in package.json
Missing metadata folder with screenshots for view commands as required for new extensions
Consider adding subtitles to commands in package.json to indicate the service
Lists in all three commands should use the isLoading prop to avoid empty state flicker
Comparison operators should use === instead of == when checking for empty strings

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{10 file(s) reviewed, 10 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/esports-pass/README.md

extensions/esports-pass/package.json

extensions/esports-pass/src/matches.tsx

extensions/esports-pass/src/results.tsx

extensions/esports-pass/src/tournaments.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

…cast-extensions into ext/esports-pass

rafaelvicio · 2025-03-01T19:55:03Z

Ready for a new review. @greptileai @greptile-apps @raycastbot

rafaelvicio · 2025-03-01T19:58:36Z

Thanks for your contribution, it could maybe make sense to unify unto one extension, I can see that we have 2/3 games in the store already made by @vimtor

https://www.raycast.com/vimtor/valorant-esports

https://www.raycast.com/vimtor/lol-esports

What do you think?

Hi, yes I know about extensions.

But the Esports Pass extension is more connected to our own API. And we have a good roadmap planned for the inclusion of new features and new games.

The next games are: Call of Duty, Dota2, EA Sports FC, LOL Wild Rift, Mobile Legends: Bang Bang, Overwatch, PUBG, Rocket League, King of Glory, Starcraft 2 and Starcraft Brood War

There will be features that are specific to connections with the user's Esports Pass account.

greptile-apps

PR Summary

(updates since last review)

This PR adds a new Esports Pass extension for viewing esports matches, results, and tournaments for popular games like League of Legends, VALORANT, and Counter-Strike.

Type error in /extensions/esports-pass/src/results.tsx where Matche[] is used instead of Match[] in the Schedule interface
Missing metadata folder with screenshots for view commands as required for new extensions
In /extensions/esports-pass/src/matches.tsx and other files, component naming is inconsistent (e.g., MatcheItem vs expected MatchItem)
Consider adding additional games from assets folder (rainbow-six.png and dota.png) to the videogames array
API calls should be wrapped in try/catch blocks for better error handling

_{11 file(s) reviewed, 5 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/esports-pass/src/constants/videogames.ts

extensions/esports-pass/src/tournaments.tsx

extensions/esports-pass/src/matches.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

…cast-extensions into ext/esports-pass

pernielsentikaer · 2025-03-02T21:26:06Z

@rafaelvicio could you have a look?

rafaelvicio · 2025-03-03T18:39:20Z

@pernielsentikaer I think this is super cool extension and we should keep it as a it is. One notable difference is that my extensions uses Riot's API so if something happened to Esports Pass the extension would become obsolete.

Probably makes sense to have both and, at some point, remove my extensions.

I agree with @vimtor , the lolesports API can also count on other championships that are not covered by our data providers. It can also be discontinued at any time, and is a valid risk on both sides.

I believe that these two extensions can coexist. @pernielsentikaer

pernielsentikaer

Hi 👋

Looks good to me, approved 🔥

github-actions · 2025-03-03T22:12:53Z

Published to the Raycast Store:
https://raycast.com/rafaelvicio/esports-pass

raycastbot · 2025-03-03T22:12:55Z

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Add esports-pass extension

18f269e

- feat: public extension - feat: change screnshots - feat: add metadata - feat: add changelog - feat: use npm - feat: fix tournament name - feat: add tournaments command - feat: refact commands - init

raycastbot added the new extension Label for PRs with new extensions label Feb 23, 2025

pernielsentikaer self-assigned this Mar 1, 2025

greptile-apps bot reviewed Mar 1, 2025

View reviewed changes

rafaelvicio and others added 11 commits March 1, 2025 12:44

Update extensions/esports-pass/README.md

e4c6e39

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update extensions/esports-pass/package.json

e98de3b

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update extensions/esports-pass/src/matches.tsx

050795c

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update CHANGELOG.md

f3a30a3

Update matches.tsx

1a4c893

Update extensions/esports-pass/src/tournaments.tsx

0fe0682

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update matches.tsx

d84ec34

Update results.tsx

58ac7e4

Update results.tsx

e136f4e

feat: pr review

c2257f0

Merge branch 'ext/esports-pass' of https://github.com/rafaelvicio/ray…

29dcfc6

…cast-extensions into ext/esports-pass

greptile-apps bot reviewed Mar 1, 2025

View reviewed changes

rafaelvicio and others added 10 commits March 1, 2025 17:04

Update extensions/esports-pass/src/constants/videogames.ts

538a3a9

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

feat: remove trailing whitespace

af1a800

Merge branch 'ext/esports-pass' of https://github.com/rafaelvicio/ray…

d09fe86

…cast-extensions into ext/esports-pass

fix: typo error

01a0d9a

feat: fix date compare

800c42a

feat: fix videogame icon

b218616

fix: length default

fff9fe1

fix: lint erro

6201737

fix: name error

d1efdd6

fix: run lint fix

9a8dd60

pernielsentikaer approved these changes Mar 3, 2025

View reviewed changes

Update CHANGELOG.md and optimise images

b44d367

raycastbot merged commit c288820 into raycast:main Mar 3, 2025
2 checks passed

Conversation

rafaelvicio commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screencast

Checklist

Uh oh!

raycastbot commented Feb 23, 2025

Uh oh!

pernielsentikaer commented Mar 1, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rafaelvicio commented Mar 1, 2025

Uh oh!

rafaelvicio commented Mar 1, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pernielsentikaer commented Mar 2, 2025

Uh oh!

rafaelvicio commented Mar 3, 2025

Uh oh!

pernielsentikaer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2025

Uh oh!

raycastbot commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rafaelvicio commented Feb 23, 2025 •

edited

Loading