Skip to content

Update safari extension#17227

Merged
raycastbot merged 6 commits intoraycast:mainfrom
niksite:ext/safari
Mar 5, 2025
Merged

Update safari extension#17227
raycastbot merged 6 commits intoraycast:mainfrom
niksite:ext/safari

Conversation

@niksite
Copy link
Contributor

@niksite niksite commented Feb 21, 2025

Description

  • Added a fuzzy search option that can be enabled/disabled via preferences
  • Improved search to match terms anywhere within bookmarks and other items

Screencast

image

Checklist

- - Add a fuzzy search option - Ensure the search term can appear anywhere in the bookmark, such as in the middle.
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: safari Issues related to the safari extension labels Feb 21, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 21, 2025

Thank you for your first contribution! 🎉

🔔 @loris @thomaspaulmann @SKaplanOfficial @iwex @xilopaint @ChangeHow @ridemountainpig @1weiho @xmok you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

@pernielsentikaer pernielsentikaer self-assigned this Feb 28, 2025
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that could make sense, and as long as it's default the same as before, it should be fine.

@loris, do you want to check this?

@pernielsentikaer
Copy link
Collaborator

@greptileai can you check 😊

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the Safari extension by adding a fuzzy search option and improving search functionality to match terms anywhere within bookmarks and other items.

  • The new CHANGELOG.md entry is incorrectly positioned - it should be at the top of the file and needs the {PR_MERGE_DATE} template string at the end of the title
  • The enableFuzzySearch preference in package.json is properly added with a default value of true, maintaining backward compatibility
  • The search function in utils.ts now uses a threshold of 0.35 when fuzzy search is enabled and adds ignoreLocation: true to match terms anywhere in content
  • The PR adds 'niksite' as a new contributor and includes fuse.js library for implementing the fuzzy search functionality

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@niksite
Copy link
Contributor Author

niksite commented Feb 28, 2025

@greptileai fixed the {PR_MERGE_DATE} in the CHANGELOG.md file.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR updates the Safari extension with a fuzzy search option and improved search functionality to match terms anywhere within bookmarks and other items.

  • The CHANGELOG.md entry now correctly uses the {PR_MERGE_DATE} template string instead of a specific date
  • The entry has been properly positioned at the top of the CHANGELOG file, following the repository guidelines
  • The PR maintains backward compatibility by setting appropriate default values for the new fuzzy search preference

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@niksite
Copy link
Contributor Author

niksite commented Mar 4, 2025

Could someone please check/merge this? This update greatly improves my QoL for bookmark searches, and I'm pretty sure other users would benefit too.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 36d7dd6 into raycast:main Mar 5, 2025
2 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Published to the Raycast Store:
https://raycast.com/loris/safari

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@niksite).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: safari Issues related to the safari extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants