Conversation
- - Add a fuzzy search option - Ensure the search term can appear anywhere in the bookmark, such as in the middle. - Initial commit
|
Thank you for your first contribution! 🎉 🔔 @loris @thomaspaulmann @SKaplanOfficial @iwex @xilopaint @ChangeHow @ridemountainpig @1weiho @xmok you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
pernielsentikaer
left a comment
There was a problem hiding this comment.
I guess that could make sense, and as long as it's default the same as before, it should be fine.
@loris, do you want to check this?
|
@greptileai can you check 😊 |
There was a problem hiding this comment.
PR Summary
This PR updates the Safari extension by adding a fuzzy search option and improving search functionality to match terms anywhere within bookmarks and other items.
- The new CHANGELOG.md entry is incorrectly positioned - it should be at the top of the file and needs the
{PR_MERGE_DATE}template string at the end of the title - The
enableFuzzySearchpreference in package.json is properly added with a default value of true, maintaining backward compatibility - The search function in utils.ts now uses a threshold of 0.35 when fuzzy search is enabled and adds
ignoreLocation: trueto match terms anywhere in content - The PR adds 'niksite' as a new contributor and includes fuse.js library for implementing the fuzzy search functionality
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
@greptileai fixed the |
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR updates the Safari extension with a fuzzy search option and improved search functionality to match terms anywhere within bookmarks and other items.
- The CHANGELOG.md entry now correctly uses the
{PR_MERGE_DATE}template string instead of a specific date - The entry has been properly positioned at the top of the CHANGELOG file, following the repository guidelines
- The PR maintains backward compatibility by setting appropriate default values for the new fuzzy search preference
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Could someone please check/merge this? This update greatly improves my QoL for bookmark searches, and I'm pretty sure other users would benefit too. |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi 👋
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@niksite). |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder