Skip to content

Add solana-wallets-generation extension#17129

Merged
raycastbot merged 19 commits intoraycast:mainfrom
uladkaminski:ext/solana-wallets-generation
Mar 11, 2025
Merged

Add solana-wallets-generation extension#17129
raycastbot merged 19 commits intoraycast:mainfrom
uladkaminski:ext/solana-wallets-generation

Conversation

@uladkaminski
Copy link
Contributor

@uladkaminski uladkaminski commented Feb 17, 2025

Description

Screencast

Checklist

- fix: resolve linting issues and improve action titles
- chore: update package-lock.json
- feat: add store metadata and screenshots
- chore: update extension icon
- docs: update changelog and add roadmap to README
- Initial commit: Solana Wallets Generation Raycast Extension
- initial commit
- Initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Feb 17, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 17, 2025

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

@pernielsentikaer
Copy link
Collaborator

@xmok do you want to check this?

@greptileai could you do the initial review

@pernielsentikaer pernielsentikaer self-assigned this Feb 28, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added a new Solana Wallets Generation extension that enables users to efficiently create multiple Solana wallets with options for public key inclusion and CSV export.

  • The CHANGELOG.md entry for version 1.0.0 should use {PR_MERGE_DATE} instead of the hardcoded date "2024-02-17" to follow repository standards
  • The swg.tsx implementation should wrap the wallet generation in a try/catch block with proper error handling to improve reliability
  • Consider adding a metadata folder with screenshots since this is a new extension with a view command
  • The wallet generation process could benefit from using showFailureToast from @raycast/utils for simplified error handling
  • The extension correctly implements the Solana Web3.js library for secure wallet generation with appropriate UI feedback

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

9 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Copy link
Contributor

@xmok xmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could simplify the extension further by removing the Form and utilizing Argument to pass the number of wallets and public key option - this would reduce the number of steps needed to generate wallets - but this is a non-blocker.

Comment on lines +51 to +55
actions={
<ActionPanel>
<Action.CopyToClipboard title="Copy All as CSV" content={csvContent} />
</ActionPanel>
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also have this Action added to the List.Item of all the other items as a secondary Action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated according to your suggestion

Comment on lines +58 to +66
<List.Item
key={index}
title={wallet}
actions={
<ActionPanel>
<Action.CopyToClipboard title="Copy to Clipboard" content={wallet} />
</ActionPanel>
}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings are pretty long so why not move them to the detail? See screenshot for ideas:

solana-suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will update this PR accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is done. Thanks

uladkaminski and others added 2 commits March 3, 2025 11:30
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
update the date to the {PR_MERGE_DATE} placeholder

Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
@pernielsentikaer
Copy link
Collaborator

Is this ready for another review?

@uladkaminski
Copy link
Contributor Author

I have a question regarding further changes. Is there a way I can pull changes made in this branch for this project to my original repo? Initially I used this process for submitting. Or should I make changes directly in this project branch?

@xmok
Copy link
Contributor

xmok commented Mar 5, 2025

Probably easiest to directly use the working branch.
But depending on how your setup is, you can try running npx @raycast/api@latest pull-contributions which should pull latest contributions.

@uladkaminski uladkaminski requested a review from xmok March 10, 2025 23:16
@uladkaminski
Copy link
Contributor Author

uladkaminski commented Mar 10, 2025

Thanks for your feedback! Sorry it took me a while to figure everything out, but I've now updated the PR based on your comments.

@xmok I decided not to migrate to arguments since there's a plan to add more settings there in the future. Also, there is a plan to use preferences for the default number of wallets and default format for copying, if that works for you.

@pernielsentikaer I've made the changes you suggested. Would appreciate if you could take a look when you have a chance

Copy link
Contributor

@xmok xmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup we're getting somewhere! Let's also add some Icons and use List.Sections.
Don't forget to lint once you're done.

And we need to update the metadata images to the new UI.
After that, LGTM.

uladkaminski and others added 6 commits March 11, 2025 09:27
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
@uladkaminski uladkaminski requested a review from xmok March 11, 2025 10:22
@uladkaminski
Copy link
Contributor Author

Icons were added. Lint is passed. Screenshots in metadata were updated.

@raycastbot raycastbot merged commit 3f57acb into raycast:main Mar 11, 2025
2 checks passed
@github-actions
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/uladkaminski/solana-wallets-generation

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@uladkaminski uladkaminski deleted the ext/solana-wallets-generation branch March 16, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new extension Label for PRs with new extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants