Add solana-wallets-generation extension#17129
Conversation
- fix: resolve linting issues and improve action titles - chore: update package-lock.json - feat: add store metadata and screenshots - chore: update extension icon - docs: update changelog and add roadmap to README - Initial commit: Solana Wallets Generation Raycast Extension - initial commit - Initial commit
|
Congratulations on your new Raycast extension! 🚀 Due to our current reduced availability, the initial review may take up to 10-15 business days Once the PR is approved and merged, the extension will be available on our Store. |
|
@xmok do you want to check this? @greptileai could you do the initial review |
There was a problem hiding this comment.
PR Summary
Added a new Solana Wallets Generation extension that enables users to efficiently create multiple Solana wallets with options for public key inclusion and CSV export.
- The CHANGELOG.md entry for version 1.0.0 should use
{PR_MERGE_DATE}instead of the hardcoded date "2024-02-17" to follow repository standards - The
swg.tsximplementation should wrap the wallet generation in a try/catch block with proper error handling to improve reliability - Consider adding a
metadatafolder with screenshots since this is a new extension with a view command - The wallet generation process could benefit from using
showFailureToastfrom@raycast/utilsfor simplified error handling - The extension correctly implements the Solana Web3.js library for secure wallet generation with appropriate UI feedback
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
9 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
xmok
left a comment
There was a problem hiding this comment.
You could simplify the extension further by removing the Form and utilizing Argument to pass the number of wallets and public key option - this would reduce the number of steps needed to generate wallets - but this is a non-blocker.
| actions={ | ||
| <ActionPanel> | ||
| <Action.CopyToClipboard title="Copy All as CSV" content={csvContent} /> | ||
| </ActionPanel> | ||
| } |
There was a problem hiding this comment.
We could also have this Action added to the List.Item of all the other items as a secondary Action.
There was a problem hiding this comment.
Updated according to your suggestion
| <List.Item | ||
| key={index} | ||
| title={wallet} | ||
| actions={ | ||
| <ActionPanel> | ||
| <Action.CopyToClipboard title="Copy to Clipboard" content={wallet} /> | ||
| </ActionPanel> | ||
| } | ||
| /> |
There was a problem hiding this comment.
Thanks, will update this PR accordingly
There was a problem hiding this comment.
This change is done. Thanks
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
update the date to the {PR_MERGE_DATE} placeholder
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
|
Is this ready for another review? |
|
I have a question regarding further changes. Is there a way I can pull changes made in this branch for this project to my original repo? Initially I used this process for submitting. Or should I make changes directly in this project branch? |
|
Probably easiest to directly use the working branch. |
|
Thanks for your feedback! Sorry it took me a while to figure everything out, but I've now updated the PR based on your comments. @xmok I decided not to migrate to arguments since there's a plan to add more settings there in the future. Also, there is a plan to use preferences for the default number of wallets and default format for copying, if that works for you. @pernielsentikaer I've made the changes you suggested. Would appreciate if you could take a look when you have a chance |
xmok
left a comment
There was a problem hiding this comment.
Yup we're getting somewhere! Let's also add some Icons and use List.Sections.
Don't forget to lint once you're done.
And we need to update the metadata images to the new UI.
After that, LGTM.
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
Co-authored-by: Syed M Mokaarim Bin Razi <30526133+xmok@users.noreply.github.com>
|
Icons were added. Lint is passed. Screenshots in metadata were updated. |
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |

Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder